Code Monkey home page Code Monkey logo

Comments (7)

AlfredXiaSF avatar AlfredXiaSF commented on June 11, 2024 1

Yes, reset_index=False works for me.

from prose.

lgrcia avatar lgrcia commented on June 11, 2024

@AlfredXiaSF , thanks for reporting!

I just pushed a fix in 843a89f (& 7bb12d4) (branch 2.3.1)

May I suggest you to switch to version 3.0.0 (documentation here)? I also fixed the bug there (f0debf2) and that will be our next well-maintained and tested version in the near future.

The tutorial should be running now but let me know if you see another issue!

from prose.

lgrcia avatar lgrcia commented on June 11, 2024

For reference: working min_separation is fixed for good in 83f55e8

from prose.

lgrcia avatar lgrcia commented on June 11, 2024

@AlfredXiaSF, that's great you gave version 3.0 a try. Thanks!

I did some test yesterday and uploaded this tutorial (same as the one you followed but on version 3.0). As you experienced there are some breaking changes in the API (hence the change of main version number). For the plate solving, working with n=30 stars works (see tutorial).

Just a note that in prose we try to have the fastest plate solving, so we make some assumptions that are sometimes at the limit of working (but lead to fast plate solving if they do). It is a matter of trade-off and it is worth a formal note on that in the documentation. I will open an issue to create some guidelines in the documentation (#60)!

This is definitely improving the package, thanks a lot!

from prose.

AlfredXiaSF avatar AlfredXiaSF commented on June 11, 2024

@lgrcia Think you!
7bb12d4 works.

I noticed I follow the wrong tutorial, so I delete the last comment and change to version 3.0.

Version works too. But there is a bug:

# show cutout around 13-th source
cutout = image.cutout(13, 300, reset_source_index=False)
cutout.show()
cutout.plot_catalog("gaia", label=True, color="w")

report:

---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
Cell In[7], line 2
      1 # show cutout around 13-th source
----> 2 cutout = image.cutout(13, 300, reset_source_index=False)
      3 cutout.show()
      4 cutout.plot_catalog("gaia", label=True, color="w")

TypeError: Image.cutout() got an unexpected keyword argument 'reset_source_index'

from prose.

lgrcia avatar lgrcia commented on June 11, 2024

My bad... this has not been refactored properly. Can you try with reset_index=False? (I am updating everything now!)

from prose.

lgrcia avatar lgrcia commented on June 11, 2024

Great! I'll close the issue then.

Note that you can use the lower-level package twirl for plate-solving (dev branch documentation here)

Thanks again for reporting this issue. Highly appreciated!

from prose.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.