Comments (10)
@AlKapkone release 0.14.0 added the option. Thanks for reporting it!
from terraform-aws-elasticsearch.
@AlKapkone release 0.14.1 has your changes. Thanks!!
from terraform-aws-elasticsearch.
@lgallard Great! Thank you so much for this amazing module!
from terraform-aws-elasticsearch.
from terraform-aws-elasticsearch.
from terraform-aws-elasticsearch.
@lgallard Hello, Luis.
Actually, it doesn't work, and I know why. I want to push my PR changes as a hotfix.
from terraform-aws-elasticsearch.
git diff --staged
diff --git a/main.tf b/main.tf
index 69cefbd..e109222 100644
--- a/main.tf
+++ b/main.tf
@@ -242,6 +242,7 @@ locals {
warm_enabled = lookup(var.cluster_config, "warm_enabled", null) == null ? var.cluster_config_warm_enabled : lookup(var.cluster_config, "warm_enabled")
warm_count = lookup(var.cluster_config, "warm_count", null) == null ? var.cluster_config_warm_count : lookup(var.cluster_config, "warm_count")
warm_type = lookup(var.cluster_config, "warm_type", null) == null ? var.cluster_config_warm_type : lookup(var.cluster_config, "warm_type")
+ cold_storage_options_enabled = lookup(var.cluster_config, "cold_storage_options_enabled", null) == null ? var.cluster_config_cold_storage_options_enabled : lookup(var.cluster_config, "cold_storage_options_enabled")
}
cluster_config = [local.cluster_config_default]
diff --git a/variables.tf b/variables.tf
index 0c8d508..9342212 100644
--- a/variables.tf
+++ b/variables.tf
@@ -253,6 +253,12 @@ variable "cluster_config_warm_type" {
default = null
}
+variable "cluster_config_cold_storage_options_enabled" {
+ description = "Indicates whether to enable cold storage for an Elasticsearch domain"
+ type = bool
+ default = false
+}
+
from terraform-aws-elasticsearch.
git push origin feature/cold-storage-variables
ERROR: Permission to lgallard/terraform-aws-elasticsearch.git denied to AlKapkone.
from terraform-aws-elasticsearch.
@AlKapkone nice catch. You can create a PR against my repo and I'll approve it or I can take the lines from your comments. You can't push directly to other repos, that's why you need to create a PR.
I rather you create a PR, this way you will appear as a contributor!
from terraform-aws-elasticsearch.
PR - #53
from terraform-aws-elasticsearch.
Related Issues (20)
- elasticsearch with cognito
- Elasticsearch with Cognito HOT 1
- Enable Ultrawarm storage option of ElasticsearchClusterConfig HOT 4
- Configuration drift for a warm node in module 0.6.0 HOT 3
- How to configure multiple AWS ElasticSearchlogs? HOT 5
- New Feature: variable create. HOT 8
- Bug: The cluster deleted and recreated after every apply HOT 5
- Add support for custom domain names on the es endpoint HOT 4
- Wrong master_user_name var when enabling advanced_security_options_internal_user_database_enabled HOT 2
- Add saml authentication support. HOT 1
- Issue with VPC config on 0.9.0 HOT 3
- zone_awareness_config block within cluster_config is not working HOT 3
- cannot enable multiple log types HOT 5
- Module fails if we create cloudwatch log group in same stack where we call the module HOT 1
- Getting clodstorage block error HOT 2
- Support for auto_tune_options HOT 2
- Support required gp3 throughput parameter
- Error: error creating IAM Service Linked Role
- Domain is getting recreated
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from terraform-aws-elasticsearch.