Code Monkey home page Code Monkey logo

Comments (10)

lgallard avatar lgallard commented on September 27, 2024 1

@AlKapkone release 0.14.0 added the option. Thanks for reporting it!

from terraform-aws-elasticsearch.

lgallard avatar lgallard commented on September 27, 2024 1

@AlKapkone release 0.14.1 has your changes. Thanks!!

from terraform-aws-elasticsearch.

AlKapkone avatar AlKapkone commented on September 27, 2024 1

@lgallard Great! Thank you so much for this amazing module!

from terraform-aws-elasticsearch.

AlKapkone avatar AlKapkone commented on September 27, 2024

Знімок екрана 2022-06-08 о 14 14 50

Enable cold storage

from terraform-aws-elasticsearch.

AlKapkone avatar AlKapkone commented on September 27, 2024

Terraform - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/elasticsearch_domain#cold_storage_options

from terraform-aws-elasticsearch.

AlKapkone avatar AlKapkone commented on September 27, 2024

@lgallard Hello, Luis.
Actually, it doesn't work, and I know why. I want to push my PR changes as a hotfix.

from terraform-aws-elasticsearch.

AlKapkone avatar AlKapkone commented on September 27, 2024
git diff --staged
diff --git a/main.tf b/main.tf
index 69cefbd..e109222 100644
--- a/main.tf
+++ b/main.tf
@@ -242,6 +242,7 @@ locals {
     warm_enabled             = lookup(var.cluster_config, "warm_enabled", null) == null ? var.cluster_config_warm_enabled : lookup(var.cluster_config, "warm_enabled")
     warm_count               = lookup(var.cluster_config, "warm_count", null) == null ? var.cluster_config_warm_count : lookup(var.cluster_config, "warm_count")
     warm_type                = lookup(var.cluster_config, "warm_type", null) == null ? var.cluster_config_warm_type : lookup(var.cluster_config, "warm_type")
+    cold_storage_options_enabled = lookup(var.cluster_config, "cold_storage_options_enabled", null) == null ? var.cluster_config_cold_storage_options_enabled : lookup(var.cluster_config, "cold_storage_options_enabled")
   }
 
   cluster_config = [local.cluster_config_default]
diff --git a/variables.tf b/variables.tf
index 0c8d508..9342212 100644
--- a/variables.tf
+++ b/variables.tf
@@ -253,6 +253,12 @@ variable "cluster_config_warm_type" {
   default     = null
 }
 
+variable "cluster_config_cold_storage_options_enabled" {
+  description = "Indicates whether to enable cold storage for an Elasticsearch domain"
+  type        = bool
+  default     = false
+}
+

from terraform-aws-elasticsearch.

AlKapkone avatar AlKapkone commented on September 27, 2024
git push origin feature/cold-storage-variables
ERROR: Permission to lgallard/terraform-aws-elasticsearch.git denied to AlKapkone.

from terraform-aws-elasticsearch.

lgallard avatar lgallard commented on September 27, 2024

@AlKapkone nice catch. You can create a PR against my repo and I'll approve it or I can take the lines from your comments. You can't push directly to other repos, that's why you need to create a PR.

I rather you create a PR, this way you will appear as a contributor!

from terraform-aws-elasticsearch.

AlKapkone avatar AlKapkone commented on September 27, 2024

PR - #53

from terraform-aws-elasticsearch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.