Code Monkey home page Code Monkey logo

Comments (2)

andy8052 avatar andy8052 commented on June 12, 2024 1

Looking at this quickly I think it looks very solid. What would you guys think about breaking out the pure ERC721 logic and then extending it with your custom logic such as resolver, totalSupplyCap and transferable.

Also, is there a reason for using init instead of just a constructor?

from lexcorpus.

Ro5s avatar Ro5s commented on June 12, 2024

Thanks for taking a look :-) ! @andy8052 We use init instead of constructor to implement minimal proxy (eip1167) for deployment of new mintable NFT to save tons on gas.

Agree that breaking out our governancy and other more custom extensions is solid direction 🚴

Would love to send $LEX your way to recognize this input! What’s a good ethereum address?

from lexcorpus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.