Comments (21)
I solved this by running with uses: lewagon/wait-on-check-action@master
haven't done a deep dive to figure out what's changed since the release but in my case it I was trying to use the feature from PR #6 which doesn't seem to be released yet.
from wait-on-check-action.
Thanks for letting me know, will fix tonight
from wait-on-check-action.
bafe56a β this should fix it, please check @codetheweb π
from wait-on-check-action.
https://github.com/lewagon/wait-on-check-action/releases/tag/v0.2 π big thanks to everyone involved! I will close the issue, feel free to reopen if any more corner cases surface
from wait-on-check-action.
I get the same thing....
from wait-on-check-action.
I solved this by running with
uses: lewagon/wait-on-check-action@master
haven't done a deep dive to figure out what's changed since the release but in my case it I was trying to use the feature from PR #6 which doesn't seem to be released yet.
Thanks @rrijkse , will try
from wait-on-check-action.
Let me know if it worked! I think I have to get serious about it and start a Changelog and regular release shedule, will be on it right after the New Year! For now using master
is the best bet
from wait-on-check-action.
Hey here, I am having the same problem.
I have 3 testing workflows + 1 continuous deployment workflow.
After the first 3 workflows successfully completed, CD workflow "CD" is still stuck:
Hints:
Maybe the checker is expecting for empty pending workflows but my CD workflow is still in progress, then it will never be processed.
from wait-on-check-action.
hi @owen2345 β can you please send me the example code from your workflow that uses the wait-on-check
?
from wait-on-check-action.
Sure @progapandist
name: Continous deployment
on:
push:
branches:
- master
- staging
# Allows you to run this workflow manually from the Actions tab
workflow_dispatch:
jobs:
deploy:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
# This step will retry until required check passes
# and will fail the whole workflow if the check conclusion is not a success
- name: Wait on tests
uses: lewagon/wait-on-check-action@master
with:
ref: ${{ github.event.pull_request.head.sha || github.sha }}
# check-name: test # name of the existing check - omit to wait for all checks
repo-token: ${{ secrets.GITHUB_TOKEN }}
wait-interval: 30 # seconds
- name: Continuos deployment
run: "..."
Please let me know if you need anything else to find the problem.
Thank you!
from wait-on-check-action.
Thank you! Try passing ref: ${{ github.sha }}
instead of ref: ${{ github.event.pull_request.head.sha || github.sha }}
. Frankly, I don't understand the use case for having a conditional between SHAs
from wait-on-check-action.
Maybe omitting check name for all checks doesn't work as expected. Can you try waiting for all three testing checks explicitly one after another and see if that works?
from wait-on-check-action.
Unfortunately it did not work (the same problem "it still stuck").
Additionally I noticed that when one of the workflows failed, my CD workflow is still stuck. I think it should fail/cancel too.
from wait-on-check-action.
Unfortunately I donβt see an immediate answer. Try referring to [email protected], do one test at a time, and pass check names explicitly. If it works, then it must be a regression in master but I have no time to investigate urgently.
from wait-on-check-action.
The problem seems to be that the workflow is waiting for itself to finish in order to continue. When the check-name
is specified, this is not a problem.
from wait-on-check-action.
Yes, that means #6 probably messed it up. Sorry for the oversight. I will try to investigate, but havenβt got a lot of free time on my hands rn. If someone can see the problem clearly and make a quick PR - that will be much appreciated!
from wait-on-check-action.
For now the solution would be to wait on check name explicitly, donβt omit it, as @matiasalbarello mentioned (thanks!)
from wait-on-check-action.
Should be fixed thanks to #10 (π @matiasalbarello), please check and confirm so I can close this issue
from wait-on-check-action.
I believe #10 introduced a new issue:
https://github.com/Baton-donation/backend/runs/1682419913?check_suite_focus=true#step:5:7
from wait-on-check-action.
Looks like it's working now, thank you!
Could you tag it too please so I can pin the version?
from wait-on-check-action.
Sure, will do it now, it's a long time coming...
from wait-on-check-action.
Related Issues (20)
- Deprecation warning: `Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3.`
- Slow set up: action takes 15-30 seconds per invokation, cache not working? HOT 1
- Feature request: Allow parallel checking for success of multiple workflows, not just multiple jobs in one workflow HOT 1
- Invalid cache key in action
- verbose: false not working
- Deprecation warnings from dependencies? HOT 2
- Missing External Checks Statuses HOT 1
- Not working with containers HOT 1
- πββοΈπββοΈ Contributors Wanted HOT 4
- Can't find `action.yml` HOT 2
- When multiple runs exist for the same head, the action should consider only the latest HOT 4
- Question: How do I use it from workflows executed in schedule
- Fails on summerwind/actions-runner:v2.304.0-ubuntu-22.04-41ebb43 HOT 1
- verbose:false not working
- Integrate with argocd
- Getting a 'Permission Denied' error with a simple use case HOT 2
- When using check-regexp, job fails if no actions were found that match that regex HOT 2
- 18n 1.1 changed fallbacks to exclude default locale HOT 1
- Bundler version not supported HOT 1
- `lewagon/wait-on-check-action` fails to run due since Bundler `2.5.0` dropped support for Ruby 2.7.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wait-on-check-action.