Code Monkey home page Code Monkey logo

Comments (21)

rrijkse avatar rrijkse commented on September 13, 2024 1

I solved this by running with uses: lewagon/wait-on-check-action@master haven't done a deep dive to figure out what's changed since the release but in my case it I was trying to use the feature from PR #6 which doesn't seem to be released yet.

from wait-on-check-action.

progapandist avatar progapandist commented on September 13, 2024 1

Thanks for letting me know, will fix tonight

from wait-on-check-action.

progapandist avatar progapandist commented on September 13, 2024 1

bafe56a β€” this should fix it, please check @codetheweb πŸ™

from wait-on-check-action.

progapandist avatar progapandist commented on September 13, 2024 1

https://github.com/lewagon/wait-on-check-action/releases/tag/v0.2 πŸŽ‰ big thanks to everyone involved! I will close the issue, feel free to reopen if any more corner cases surface

from wait-on-check-action.

YonatanKra avatar YonatanKra commented on September 13, 2024

I get the same thing....

from wait-on-check-action.

ayozemr avatar ayozemr commented on September 13, 2024

I solved this by running with uses: lewagon/wait-on-check-action@master haven't done a deep dive to figure out what's changed since the release but in my case it I was trying to use the feature from PR #6 which doesn't seem to be released yet.

Thanks @rrijkse , will try

from wait-on-check-action.

progapandist avatar progapandist commented on September 13, 2024

Let me know if it worked! I think I have to get serious about it and start a Changelog and regular release shedule, will be on it right after the New Year! For now using master is the best bet

from wait-on-check-action.

owen2345 avatar owen2345 commented on September 13, 2024

Hey here, I am having the same problem.
I have 3 testing workflows + 1 continuous deployment workflow.
After the first 3 workflows successfully completed, CD workflow "CD" is still stuck:
Screen Shot 2021-01-07 at 6 06 13 AM

Hints:
Maybe the checker is expecting for empty pending workflows but my CD workflow is still in progress, then it will never be processed.

from wait-on-check-action.

progapandist avatar progapandist commented on September 13, 2024

hi @owen2345 β€” can you please send me the example code from your workflow that uses the wait-on-check?

from wait-on-check-action.

owen2345 avatar owen2345 commented on September 13, 2024

Sure @progapandist

name: Continous deployment

on:
  push:
    branches:
      - master
      - staging

  # Allows you to run this workflow manually from the Actions tab
  workflow_dispatch:

jobs:
  deploy:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
      # This step will retry until required check passes
      # and will fail the whole workflow if the check conclusion is not a success
      - name: Wait on tests
        uses: lewagon/wait-on-check-action@master
        with:
          ref: ${{ github.event.pull_request.head.sha || github.sha }}
          # check-name: test # name of the existing check - omit to wait for all checks
          repo-token: ${{ secrets.GITHUB_TOKEN }}
          wait-interval: 30 # seconds

      - name: Continuos deployment
        run: "..."

Please let me know if you need anything else to find the problem.
Thank you!

from wait-on-check-action.

progapandist avatar progapandist commented on September 13, 2024

Thank you! Try passing ref: ${{ github.sha }} instead of ref: ${{ github.event.pull_request.head.sha || github.sha }}. Frankly, I don't understand the use case for having a conditional between SHAs

from wait-on-check-action.

progapandist avatar progapandist commented on September 13, 2024

Maybe omitting check name for all checks doesn't work as expected. Can you try waiting for all three testing checks explicitly one after another and see if that works?

from wait-on-check-action.

owen2345 avatar owen2345 commented on September 13, 2024

Unfortunately it did not work (the same problem "it still stuck").
Additionally I noticed that when one of the workflows failed, my CD workflow is still stuck. I think it should fail/cancel too.

from wait-on-check-action.

progapandist avatar progapandist commented on September 13, 2024

Unfortunately I don’t see an immediate answer. Try referring to [email protected], do one test at a time, and pass check names explicitly. If it works, then it must be a regression in master but I have no time to investigate urgently.

from wait-on-check-action.

matiasalbarello avatar matiasalbarello commented on September 13, 2024

The problem seems to be that the workflow is waiting for itself to finish in order to continue. When the check-name is specified, this is not a problem.

from wait-on-check-action.

progapandist avatar progapandist commented on September 13, 2024

Yes, that means #6 probably messed it up. Sorry for the oversight. I will try to investigate, but haven’t got a lot of free time on my hands rn. If someone can see the problem clearly and make a quick PR - that will be much appreciated!

from wait-on-check-action.

progapandist avatar progapandist commented on September 13, 2024

For now the solution would be to wait on check name explicitly, don’t omit it, as @matiasalbarello mentioned (thanks!)

from wait-on-check-action.

progapandist avatar progapandist commented on September 13, 2024

Should be fixed thanks to #10 (πŸ™Œ @matiasalbarello), please check and confirm so I can close this issue

from wait-on-check-action.

codetheweb avatar codetheweb commented on September 13, 2024

I believe #10 introduced a new issue:
https://github.com/Baton-donation/backend/runs/1682419913?check_suite_focus=true#step:5:7

from wait-on-check-action.

codetheweb avatar codetheweb commented on September 13, 2024

Looks like it's working now, thank you!

Could you tag it too please so I can pin the version?

from wait-on-check-action.

progapandist avatar progapandist commented on September 13, 2024

Sure, will do it now, it's a long time coming...

from wait-on-check-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.