Comments (3)
This is because keys set is artificial and have unfortunate hash code distribution. Integer.hashCode()
is the value primitive itself. If hash codes are not mixed, this performs really bad with linear hashing.
By default Koloboke doesn't mix Object
keys' hashCodes (Koloboke does mix only primitive keys by default), assuming hash distribution is good because hashCode() on the keys is implemented properly. This doesn't hold in the cases like your test; but there is ability to workaround that by providing custom equivalence, if you cannot fix the keys' hashCode() implementation, like in the case with Integer
:
this.testedMap = HashObjIntMaps.<Integer> getDefaultFactory()
.withHashConfig(HashConfig.fromLoads(KolobokeObjectIntIssue.LOAD_FACTOR / 2,
KolobokeObjectIntIssue.LOAD_FACTOR, KolobokeObjectIntIssue.LOAD_FACTOR))
.withKeyEquivalence(new StatelessEquivalence<Integer>() {
@Override
public boolean equivalent(@Nonnull Integer i1, @Nonnull Integer i2) {
return i1.intValue() == i2.intValue();
}
@Override
public int hash(@Nonnull Integer i) {
return i * -1640531527; // magic mix
}
})
.newMutableMap(KolobokeObjectIntIssue.TARGET_SIZE);
Apparently, Fastutil does always mix keys' hash codes, including when they are Objects.
Applying this fix, you will see that libs are performing ~ equally. (Your might see considerably different numbers, but that's because of poor benchmarking; implement tests in JMH and you will see that they are indeed performing very close.)
from koloboke.
Thanks for your reply, Roman !
I think I see your point : trust the hashCode(), else switch to "custom hash" approach. Why not ? Performance-wise, inlining offers comparable performance for both in the end. The only problem I see is that both are not stricly equivalent, since the custom hash may only access Object public data.
Indeed, Fastutil, HPPC* are re-hashing systematically, so are more resillient to bad-behaving Objects.
Anyway I'll be able to include Koloboke back to my JMH set, now.
from koloboke.
The only problem I see is that both are not stricly equivalent, since the custom hash may only access Object public data.
@vsonnier if incapsulated object has poor hash code implemention (for example, not accounting all fields, participating equivalence checks), Fastutil / HPPC approach won't help either, because it also could work only with hash value, returned from keys' hashCode() calls. I. e. it is strictly equivalent to Koloboke with cusom key equivalence (mixing).
from koloboke.
Related Issues (20)
- Koloboke jar size HOT 4
- Getters supporting optimistic read locking (StampedLock)
- putAll not overriden HOT 2
- Is it possible to allocate exact capacity? HOT 1
- Allow to disable usage of sun.misc.Unsafe in koloboke compile
- What is the license Koloboke and Koloboke compiler shipped with? HOT 4
- Koloboke Compile: NullPointerException at compile time
- Redundant cast warning in code generated by KolobokeMap
- Koloboke Fails to Compile on Java 9 HOT 5
- Performance issues when copying between Koloboke sets HOT 2
- build error using ./gradlew :buildMeta HOT 1
- failed to build with error below HOT 2
- java.lang.ClassCastException in very specific case on compiled ObjIntMap<String>.keySet().retainAll(...) HOT 2
- Koloboke annotation issue running Chronicle XCL tests... HOT 1
- Incorrect behavior of MutableLHashSeparateKVLongObjMapGO cursor
- Could not initialize class com.koloboke.collect.map.hash.HashIntObjMaps$DefaultFactoryHolder HOT 1
- MutableQHashSeparateKVLongObjMap rehash BUG
- koloboke.com seems to point to a wrong website
- Can't build the project
- The project can not be built
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from koloboke.