Limit when offset is set needs to be limit = limit + offset about levelgraph HOT 8 OPEN

Nice catch! :D May I ask you to submit a pull request?

from levelgraph.

Continuing on the discussion here: 86847a4#commitcomment-6691590

What if we implement a getStream which accepts as an option to start from a certain triple? That's a good way to paginate, yet you will not give a page=X, but now you will give a starttriple=SPO instead.

from levelgraph.

Yes, that was what I was thinking. It's a good way to go. Would you like to
be a contributor here? So we might work on this together.

from levelgraph.

Continuing in a new issue as this is getting off topic: #81

from levelgraph.

bump... was this ever fixed?

from levelgraph.

Definitely not, the whole 'limit + offset' thing is kind of broken if you read the whole discussion.

The right approach will be to start reading back from where it left, e.g. giving a startTriple parameter.

Anyway, @neonstalwart would you like to submit a PR on this issue? Maybe with @pietercolpaert fix + unit tests?

from levelgraph.

Yes, pagination using the last key info is right way. I've added the 'last' event
and next option to solve the stream pagination problem in level-subkey. Just reference:

var callbackStream = require('callback-stream')

var lastKey = null;
function nextPage(db, aLastKey, aPageSize, cb) {
  var stream = db.readStream({next: aLastKey, limit: aPageSize})
  stream.on('last', function(aLastKey){
    lastKey = aLastKey;
  });

  stream.pipe(callbackStream(function(err, data){
    cb(data, lastKey)
  }))

}

var pageNo = 1;
dataCallback = function(data, lastKey) {
    console.log("page:", pageNo);
    console.log(data);
    ++pageNo;
    if (lastKey) {
      nextPage(db, lastKey, 10, dataCallback);
    }
    else
      console.log("no more data");
}
nextPage(db, lastKey, 10, dataCallback);

from levelgraph.

👍 to removing offset entirely in favor of adding start or startTriple syntax.

Pretty limited pagination options atm...heh...

from levelgraph.