Code Monkey home page Code Monkey logo

Comments (1)

roydukkey avatar roydukkey commented on June 11, 2024

lerna/libs/commands/publish/src/index.ts

Lines 1124 to 1126 in 13c80ae

if (!pkg.lernaConfig?.command?.publish?.assets) {
return;
}

Actually, I wonder too if the preceding conditionally never gets the configuration from the following code:

lerna/libs/commands/publish/src/index.ts

Lines 297 to 306 in 13c80ae

} else if (this.project.config.command?.publish?.["assets"]) {
// Root level
const assets = this.project.config.command?.publish?.["assets"].map((asset) =>
interpolateAsset(asset, interpolateStr)
);
pkg.lernaConfig = pkg.lernaConfig || {};
pkg.lernaConfig.command = pkg.lernaConfig.command || {};
pkg.lernaConfig.command.publish = pkg.lernaConfig.command.publish || {};
pkg.lernaConfig.command.publish.assets = assets;
}

I do see this log for the my configuration, but this conditional still catches and returns early.

lerna verb silly Interpolated string "../../README.md" for node "package-a" to produce "../../README.md"
{
  "$schema": "node_modules/lerna/schemas/lerna-schema.json",
  "npmClient": "pnpm",
  "version": "independent",
  "changelogPreset": "conventional-changelog-conventionalcommits",
  "command": {
    "version": {
      "message": "chore(release): publish",
      "conventionalCommits": true,
      "private": false
    },
    "publish": {
      "registry": "https://npm.pkg.github.com/",
      "private": false,
      "assets": [
        "../../README.md"
      ]
    }
  }
}

from lerna.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.