Code Monkey home page Code Monkey logo

Comments (12)

leostera avatar leostera commented on August 17, 2024

@BenjaminHae so I followed the specs and looked up how Github did their integration, but it doesn't seem to be working. Any advice?

from tldr.jsx.

leostera avatar leostera commented on August 17, 2024

Ah, according to this: https://code.google.com/p/chromium/issues/detail?id=58801#c3 and this: http://dev.chromium.org/tab-to-search, it will work automatically for a root domain, but not for a path.

from tldr.jsx.

leostera avatar leostera commented on August 17, 2024

I'll make a point to include a "Install search in your browser" link/button during the redesign, leaving this open for further reference.

from tldr.jsx.

igorshubovych avatar igorshubovych commented on August 17, 2024

@Ostera as far as I understood those specs we don't need .com domain. we can host all of this (your tool) on tldr-pages.github.io.

from tldr.jsx.

leostera avatar leostera commented on August 17, 2024

@igorshubovych as long as it's pathless then it's fine. We can add the OpenSearch spec at the tldr-pages.github.io level and have it forward the searches to ostera.io/tldr.jsx. I'll submit a PR.

from tldr.jsx.

igorshubovych avatar igorshubovych commented on August 17, 2024

how about just hosting tldr.jsx on tldr-pages.github.io?

from tldr.jsx.

leostera avatar leostera commented on August 17, 2024

Will be the exact same unless we make tldr-pages.github.io be the web-client. It can't have a path.

So tldr-pages.github.io/tldr.jsx won't work either.

from tldr.jsx.

igorshubovych avatar igorshubovych commented on August 17, 2024

yes, but your client is just JS, you can include that JS/CSS into main page.

from tldr.jsx.

leostera avatar leostera commented on August 17, 2024

If we did, then on every new build we'd have to manually update the site. Having an iframe that loads the page saves us a lot of pain and still maintains the tldr-pages being the tldr-pages.

from tldr.jsx.

igorshubovych avatar igorshubovych commented on August 17, 2024

We can push only certain (stable) versions on site.

from tldr.jsx.

leostera avatar leostera commented on August 17, 2024

I work on feature branches (see my PR's to this repo), the master branch will always be the latest stable version of tldr.jsx

from tldr.jsx.

leostera avatar leostera commented on August 17, 2024

Anywho, this is no longer about the OpenSearch. The file is there and I'll include it as an option if we don't use a domain for it, and if we do it'll just work. Closing now.

from tldr.jsx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.