Code Monkey home page Code Monkey logo

Comments (13)

iDylanK avatar iDylanK commented on June 15, 2024 1

Hi, we did not get any time to work with SwiftUI since.
I'll try to have a look at it again this week.

from lnpopupcontroller.

LeoNatan avatar LeoNatan commented on June 15, 2024

Hello,

What happens if you add LNPopupUI instead? In the demo project of LNPopupUI, I am able to see previews with the popup bar, or at least was possible the last time I tried.

If your project compiles normally with LNPopupController, but fails to build previews, I'd lay the blame with Xcode.

Please test with LNPopupUI, and then we'll see what we can be done for LNPopupController.

Thanks

from lnpopupcontroller.

LeoNatan avatar LeoNatan commented on June 15, 2024

https://github.com/LeoNatan/LNPopupUI

from lnpopupcontroller.

LeoNatan avatar LeoNatan commented on June 15, 2024

Also, which variant did you use, the dynamic framework or static library? I remember some issues in the past complaining about one or the other.

from lnpopupcontroller.

LeoNatan avatar LeoNatan commented on June 15, 2024

See this issue here:

LeoNatan/LNPopupUI#23

from lnpopupcontroller.

iDylanK avatar iDylanK commented on June 15, 2024

Thank you for your quick response.
We started using SwiftUI for some new views in our large UIKit based application, so we need to keep using LNPopupController. Inside these new SwiftUI views, LNPopupController is not used.

The project itself compiles without any problems.

I tried adding it statically, but unfortunately this does not resolve this issue.

from lnpopupcontroller.

LeoNatan avatar LeoNatan commented on June 15, 2024

Could you please create a small project recreating the issue?

I'm not sure what I can do if it's an Apple bug. SPM still does not support mixed-language targets, so I have to split the library into two targets, and import one from the other.

from lnpopupcontroller.

LeoNatan avatar LeoNatan commented on June 15, 2024

Maybe I can expose the LNPopupController-ObjC target, but that seems ugly to me.

from lnpopupcontroller.

iDylanK avatar iDylanK commented on June 15, 2024

Our project is split into multiple sub packages, one of which is a Presentation package.
The presentation package includes the LNPopupController package in its package.swift file.

If I add LNPopupController to the 'Package dependencies' of the whole project it seems to work.

In a demo project however, it also works when LNPopupController is only included in the sub package.
So the issue might also be specific to our project, but I can't figure it out just yet.

from lnpopupcontroller.

LeoNatan avatar LeoNatan commented on June 15, 2024

🤦‍♂️

Everything is so broken with Apple toolchains. Could you post the whole log?

Another thing I can suggest which will solve the issue for sure is bringing LNPopupController as a git submodule and adding it as a subproject of your presentation project.

from lnpopupcontroller.

LeoNatan avatar LeoNatan commented on June 15, 2024

Hello,

Has there been progress on this issue?

from lnpopupcontroller.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.