improve the Isitdown module about leon HOT 20 OPEN

Okay cool! Please reference your PR to this issue once it's done 👍

from leon.

Done for now. Will read a bit more on documentation and I'll try to develop it asap 😄

from leon.

🔧 Improve Is It Down module with a given list of popular websites

from leon.

Hello @sh1ftsh,

Thanks for this suggestion.

This is something we could indeed do.

Is that something you would like to work on?

from leon.

I'm interested to do this one as first issue if you both agree.

from leon.

Hello @adrijere,

Yeah with pleasure, go for it 👍

from leon.

Hello,
sorry for the response time
thanks the for comments, and for sure I want to work on this one too

from leon.

Hey! Is this still open? Can I pick it up?

from leon.

Hello @VMinhoto,

The module is done but can be improved, feel free to do it 😉

from leon.

I can try to improve that! The issue is:
Asking for
is gitub up ? instead of is github.com up? right?

from leon.

Indeed! And for the "most popular" ones.

from leon.

I see several ways to accomplish this. Will list them with cost/benefit explanation and could you guys select one depending on what you really want implemented:

• Have a list of all websites registered and search them for the required string - Would not advise this as there are billions of billions websites domain listed and it probable wold cause memory issues (and probably would take a lot of time to search on such a huge list of texts)
• Have a list of possible domains (.com, .org, etc.) and iterate through them - Problem with this would be country specific domains. Ping all possible combinations of the target string and the .xxx would probably take too much time.
• Hybrid Solution - Ping the most popular .xxx (.org, .com, .edu, etc.) and if it not finds it there ask the user for more information.

In my opinion the Hybrid Solution would be the best one, but what do you guys think about this?

from leon.

Thanks for putting it here.

The hybrid solution looks good, however we cannot ensure that the domain name is the right one in that way. Two websites might have the same name and then one could have xxx.com and another xxx.io.

So my suggestion here is to create a list of the most popular ones and do a mapping of it, in case the list start to grow quite well, then we could think of optimization (alphanumeric indexing, etc.).
If it is not found, then we could fallback into the hybrid solution.

Also please note that this list must be part of the module config file, so it is easy for everyone to edit it and let fellows add their own favorite mappings. Most of the time, people will not need 99% of the other mappings actually.

And if a domain name is already provided as input, then it should trigger the current behavior.

What do you think?

from leon.

Hey again several more questions. Sry about the interrogations, but trying to get the 'requirements' before actually start implementing :).

• When you say list of the most popular ones are talking about a list of popular full websites? Like:

github.com
google.com
amazon.com
...

• Yes it makes sense that the list should be at the config file yes!

• Yes if domain name is provided as input it should maintain the current behavior.

from leon.

No problem, don't hesitate to ask 😄

Yes, I'm talking about a mapping like so: github => github.com; google => google.com, etc.

from leon.

Cool! Problem that comes to mind. What of websites for multiple contries. For example amazon can be:

amazon.com
amazon.es
amazon.uk

What should it actually return? Defaulting to the country of the user? Or just the .com ?

from leon.

Always take the main one, in the case of Amazon, it is indeed the .com TLD. Most of the popular website will take over from their and bind the right servers under the hood.

from leon.

It's pretty much done the searching part, however I'm having trouble recognizing entities in the querry. The main problems I am having are:

1. Failing to run package

• If asked: Is google.com up? it answers: I am now requesting Google. Google is running correctly.

• However if asked: Is google up? it doesn't recognize google as an entity, therefor it doesn't even run the package. It just answers Good afternoon!

2. Multiple queuing

• If asked Check if github.com and nodejs.org are up it correctly answers: I'm trying to reach Github. Github is running correctly. I am now requesting Nodejs. Nodejs is up.
• But if asked Check if github and nodejs are up it answeres: Please provide me at least one valid domain name.. It fails to recognize any identitity, even the question Check if github is up is working correctly.

Is there any way i can manipulate entity recognition to recognize several entities in the same setence?

from leon.

Hi is this issue still free ? I would like to try working on it as my first issue.

from leon.

Yes, this issue is still free! Feel free to do it! Thanks for asking @jSAMUELj!

from leon.