recursive_remove.cc: fail to build about saunafs HOT 4 CLOSED

I found the cause. On arm64, an implicit char is unsigned (whereas on x86 it is signed).

Since I'm assuming the arm architecture is out of your scope, I will close this.

from saunafs.

I found the cause. On arm64, an implicit char is unsigned (whereas on x86 it is signed).
Since I'm assuming the arm architecture is out of your scope, I will close this.

While it's true that ARM64 is a low priority for us, that doesn't mean we don't want to improve it.

We checked yesterday and found the same exact issue (char is unsigned on arm, versus signed on x86). Everywhere else it uses int but in this specific instance it's using char for some reason. It compiles everything when it's changed to int.

We know ARM64 has definite problems, especially regarding performance. So we would be happy if people who use ARM can continue reporting issues like these, especially because we are focused on x86.

I would even accept PR's for improvement regarding ARM64, otherwise I think we can fix this particular issue in a few days in the dev branch.

from saunafs.

Thanks, I'm happy to hear that!

from saunafs.

Fixed in dev branch

from saunafs.