Const enum pitfalls... about udsv HOT 6 CLOSED

can you check if the latest commit fixes it?

update your dependency in package.json with the github commit link:

"udsv": "leeoniya/uDSV#0c191e8a80e7b0d78bfd0bf6ec37dc576deefbde

then run npm install again

from udsv.

A few other discussions that you might find useful in this context:

• Exporting enum in .d.ts leads to „Can't resolve” error
• Enums in typescript d.ts file
• Enum from .d.ts works for value comparison but not name comparison

from udsv.

sooo, since this is a JS codebase, changing to regular enum in the .d.ts file is inconsequential.

the question becomes if i ever want to migrate to TS if this change would prevent inlining, which i want to retain.

i guess this is the answer:

the build step they link to is in a Gulpfile, so will need to be different for a Rollup/TS setup, but should be straightforward with something like https://www.npmjs.com/package/@rollup/plugin-replace

from udsv.

@leeoniya Thanks for your comments. I should have explained my issue in more detail and maybe you would have a suggestion to fix it. But I did not get a chance to create an MRE before. I think I have something now that should be pretty easy to reproduce.

Let's say I create a simple React app that uses Typescript using:

npx create-react-app my-app --template typescript

Now I want to use your excellent udsv library with it so I add it:

npm i udsv

Then I add the following two simple lines near the top of App.tsx:

import { SchemaColumnType } from 'udsv';
const foo = SchemaColumnType.Number;

This produces the following error warning on the second line above:

TS2748: Cannot access ambient const enums when the '--isolatedModules' flag is provided.

So, const enums cannot be used with isolatedModules. Fine, so I will disable isolatedModules in tsconfig.json which eliminates this warning but does not solve the problem.

    ...
    isolatedModules": false
    ...

Now I get the following error message(s):

udsv__WEBPACK_IMPORTED_MODULE_3__.SchemaColumnType is undefined
...
export 'SchemaColumnType' (imported as 'SchemaColumnType') was not found in 'udsv' (possible exports: inferSchema, initParser)

Any thoughts?

from udsv.

Well phooey. Enums inside .d.ts files are of no use in such cases (as you already pointed out in your comments as this is a JS codebase).

from udsv.

Thanks for the update, @leeoniya. However, unfortunately, I am getting the same error message (I tried the same update in my own local copy earlier and it did not work).

I am fairly convinced after reading this that having the enum just in the .d.ts file will not work. So, please don't waste any more of your (valuable) time on this issue. Someday, if you decide to switch to Typescript, I will drop by and help out.

from udsv.