Comments (8)
can no longer repro the bug this morning
from ledger-live-desktop.
ok the issue is that the 2 last point are pointing to the same date.
for countervalues we use "close" date value so basically Jul 09 at 00:00 should be a lookup in Jul 08 (Jul 08 whole day countervalue is stored on 2018-07-08 but in reality is at time Jul 09 00.00). if we do - 1 ms
as a hack somewhere it would fix the problem but need to think this a bit more. cc @meriadec
from ledger-live-desktop.
like this hack literally work but meh.
from ledger-live-desktop.
I think something more fundamental wrong is going on btw
look at this graph, it's saying 2018-07-08 but on the axis it's Jul 9
from ledger-live-desktop.
this can wait after the release. focus on other things ;)
from ledger-live-desktop.
2 things:
- "can't repro bug this morning" : not really, the "bug" (which is not really a bug) is present this morning, but we don't see it because...it's the morning and the 2 points for today are too close
- the date problem comes from the fact the date is just an ISOString cutted at 0-10 indexes. With the format fix commit, the dates are correct (and in the right format)
If you launch the tests in live-common, you will see there is two items for the same date at the end of the array. It's not a regression, always been like that.
from ledger-live-desktop.
@meriadec no actually i can repro xD but yeah. mmh no the problem is that we build date with the start of the day and not at the "end of the previous day" (it needs to be like this to reflect what we actually do on countervalue api) and it's my fault, it's a regression in live-common. i just locally fixed it from live-common and i think that's all we need to do
helpers/account.js, getBalanceHistory
t = new Date(startOfDay(t) - 1) // midnight yesterday
don't worry about the bug for now, we need to focus on the release
from ledger-live-desktop.
will do PR for the date format though
from ledger-live-desktop.
Related Issues (20)
- Feature request support for Optimism and L2 Ethereum rollups
- XRP transaction log doesn't show account deletion transaction
- I'm being shown onboarding, even though I used this a month ago just fine? HOT 1
- 2.40.4 Black Screen on Fedora 36 Wayland HOT 2
- Cannot update Ledger Live AppImage
- Ledger Live not showing Tokemak price
- Cosmos on Ledger live HOT 6
- Error: "Sorry, Internet seems down"
- support libfuse3 (Ubuntu 22.04 LTS jammy)
- Segwit by itself should mean Native segwit.
- Saving operation history doesn't save to file HOT 1
- Solana delegated assets are ignored in portfolio HOT 1
- Fail to connect Firo Electrum to Ledger Live
- [Portfolio Display] Bitcoin missing after sending from ledger to same ledger (different accounts)? HOT 7
- Spam/Scam token on Polygon shows in desktop: SSX HOT 3
- Ledger Live 2.42.0 Bypasses password-entry? HOT 1
- COSMOS App IBC issue
- Allow rollback of a ledger app!
- sending bitcoin transaction is pending endlessly
- getVarint called with unexpected parameters when sending 2.43.1 version
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ledger-live-desktop.