two last point on graph use same countervalue about ledger-live-desktop HOT 8 CLOSED

can no longer repro the bug this morning

from ledger-live-desktop.

ok the issue is that the 2 last point are pointing to the same date.

for countervalues we use "close" date value so basically Jul 09 at 00:00 should be a lookup in Jul 08 (Jul 08 whole day countervalue is stored on 2018-07-08 but in reality is at time Jul 09 00.00). if we do - 1 ms as a hack somewhere it would fix the problem but need to think this a bit more. cc @meriadec

from ledger-live-desktop.

like this hack literally work but meh.

from ledger-live-desktop.

I think something more fundamental wrong is going on btw

look at this graph, it's saying 2018-07-08 but on the axis it's Jul 9

from ledger-live-desktop.

this can wait after the release. focus on other things ;)

from ledger-live-desktop.

2 things:

• "can't repro bug this morning" : not really, the "bug" (which is not really a bug) is present this morning, but we don't see it because...it's the morning and the 2 points for today are too close
• the date problem comes from the fact the date is just an ISOString cutted at 0-10 indexes. With the format fix commit, the dates are correct (and in the right format)

If you launch the tests in live-common, you will see there is two items for the same date at the end of the array. It's not a regression, always been like that.

from ledger-live-desktop.

@meriadec no actually i can repro xD but yeah. mmh no the problem is that we build date with the start of the day and not at the "end of the previous day" (it needs to be like this to reflect what we actually do on countervalue api) and it's my fault, it's a regression in live-common. i just locally fixed it from live-common and i think that's all we need to do

helpers/account.js, getBalanceHistory

  t = new Date(startOfDay(t) - 1) // midnight yesterday

don't worry about the bug for now, we need to focus on the release

from ledger-live-desktop.

will do PR for the date format though

from ledger-live-desktop.