Code Monkey home page Code Monkey logo

Comments (7)

valpinkman avatar valpinkman commented on August 17, 2024 2

After a talk with @khalilbenihoud, we've decided to remove the cursor pointer everywhere (except for links), at least until we rework a custom toolbar.

from ledger-live-desktop.

 avatar commented on August 17, 2024 1

I see.

Might then be worth looking at alternative solutions, e.g. Atom app displays the native title bar:

Ledger Live (Desktop) - example of window frame on Atom app

But also on macOS apps usually don't have "pointer" cursors at all (click on image to see the video):

Atom app example

Or you can just keep an issue open until possibly Electron will resolve it...

from ledger-live-desktop.

gre avatar gre commented on August 17, 2024

Thanks for the issue.
It seems this is a current limitation of Electron electron/electron#13104

from ledger-live-desktop.

gre avatar gre commented on August 17, 2024

it looks like https://electronjs.org/docs/api/frameless-window#custombuttonsonhover would fix it however you no longer see the native button which is not really good option to me

a

from ledger-live-desktop.

gre avatar gre commented on August 17, 2024

to retake Atom's example, it does not look like so consistent.
I guess not using pointer at all for the header buttons could be a tmp solution. the fact it hover with a background color make it pretty clear it's an action.

a

from ledger-live-desktop.

meriadec avatar meriadec commented on August 17, 2024

IMO: If we choose to put cursor default on some buttons, we should do it for all buttons/interactive boxes (except for links like). It's a more native approach and I recommend.

If not, I would go for custombuttonsonhover which is pretty quick to implement.

from ledger-live-desktop.

gre avatar gre commented on August 17, 2024

cc @bscholving

from ledger-live-desktop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.