Fetch: Support object literal serialization (as JSON) about bliss HOT 9 OPEN

Use the Bliss $.type() function. Your check would fail if the object comes from another window/frame.

from bliss.

Is the fetch function still needed? Is it stated somewhere what range of browser versions this is now intended for?

from bliss.

I'm already wrapping Bliss.fetch, so I'm not in a hurry to get this added. I mainly wanted to share my discoveries (I tried to solve this using query strings at first).

Converting ex: {foo: {bar: 1, x: {y: 'z'}} to foo[bar=1]&foo[x][y]=z requires recursion. In the simplest form, something like this:

// Note: This is simplified/dumb version of https://github.com/friday/query-string-encode

function queryStringEncode(input) {
    // Array of path/value tuples
    var flattened = [];

    (function flatten(input, path) {
        // Add path and value to flat array
        if ([Boolean, Number, String].indexOf(input.constructor) !== -1) {
            var serializedPath = path.map(function (key, index) {
                return index ? "[" + key + "]" : key;
            }).join("");
            flattened.push([serializedPath, input]);
        }

        // Iterate over next level of array/object
        else if ([Array, Object].indexOf(input.constructor) !== -1) {
            for (var key in input) {
                flatten(input[key], path.concat([key]));
            }
        }
    })(input, []);

    // Convert array to query string
    return flattened.map(function (pair) {
        return pair.map(encodeURIComponent).join("=");
    }).join("&");
}

from bliss.

The thing is, sometimes we want to send the actual object, e.g. uploading File objects.
So we need to be careful where we apply this stringification.

from bliss.

Yes. Only object literals or objects created with new Object() should be supported imo. This can be checked using the constructor (and probably many other ways)

({}).constructor === Object // true
new Blob().constructor === Object // false
new FormData.constructor === Object // false

from bliss.

Oh yeah, I recall something about this. Seems this applies to my suggestion as well :(

from bliss.

Seems this applies to my suggestion as well :(

What do you mean?

from bliss.

Oh, I read that too quickly. Nevermind the "as well" part of the comment.

from bliss.

Perhaps not @joyously. However Bliss's Fetch implementation is not a polyfill. It's different from the Fetch standard in small ways that means people who use it can't just drop-in replace the native browser Fetch or a polyfill.

The browser support for Fetch is very good today. When the Fetch API standard was released and got initial browser support you couldn't get any upload/download progress or abort the request. AbortController and ReadableStream were added later to solve that. They're also well supported today, but this adds to more differences in the Fetch API implementation and Bliss's Fetch.

However you're probably right that this issue may not be important today anymore. I'll leave that decision to Lea.

from bliss.