Unit test failures about moodle-block_advnotifications HOT 3 CLOSED

Thanks @XTRage - I see what you mean about the table names - will push a fix for that.

Not sure what you mean with the last sentence though? Where am I printing output in testcases? Is that not Moodle/PHPUnit doing so? Currently, the plugin doesn't have automated tests included with the plugin (except TravisCI) and 'provider_testcase::test_metadata_provider' is executed by core Moodle from /moodle/privacy/tests/provider_test.php:115 (Moodle v3.9)

from moodle-block_advnotifications.

Thank you for your quick reply.

About the other thing:

There was 1 risky test:

1. provider_testcase::test_component_understands_deleted_users with data set "block_advnotifications" ('block_advnotifications', 'block_advnotifications\privac...ovider')
   This test printed output: Getting contexts for userid...
   Done 'Getting contexts for userid...'

It is just about printing some output during the test (you are doing it with mtrace) and PHPUnit marking those as "risky" tests with its out-of-the-box Moodle configuration/distribution.
But as I said, just nitpicking, PHPUnit shuts up when "beStrictAboutOutputDuringTests" is set to false.

from moodle-block_advnotifications.

Thanks again for the report and detailed info, @XTRage! Thanks to Open Source magic, @gustavorivas96 has addressed the above issues in the latest pull request. 👌

I'll push the fixes to the Moodle Plugins directory as soon as I can.

from moodle-block_advnotifications.