cannot enable `learn` plugin about kolibri HOT 5 CLOSED

Fixed in 3206d43

from kolibri.

Two options:

1. Running django.setup() before enabling/disabling a plugin (in kolibri.utils.cli.plugin). That way, we just know that the django stack is ready when loading kolibri_plugin which requires less carefulness when writing plugins.

2. Moving the import of urls modules to MyKolibriPlugin.url_module. This way, we know that loading kolibri_plugin is less error prone because it doesn't depend on a functional django stack. So for instance if a plugin has broken something in the Django stack (for instance its views or models are invalid), we can still enable/disable the plugin.

from kolibri.

I'm wondering if option 2 is too restrictive. That way, a plugin cannot access its own models when it's being enabled. On the other hand, things like migrations may not have been fired.

Can anybody advice on what plugins currently HAVE to be able to do when enabled? I can't see that any of the core plugins have custom enable() class methods anyways.

from kolibri.

I'm wondering if option 1 is too restrictive. That way, a plugin cannot access its own models when it's being enabled. On the other hand, things like migrations may not have been fired.

Following up on this: Since one may run enable->disable->enable, with each operation starting and exiting Kolibri, I believe that plugins should not make lots of assumptions about initial states while running enable. This is just a caution.

Anyways, because commands such as collectstatic and migrate have to be run, we also have to run django.setup() anyways.

Here's a rough vision of what enabling a plugin could look like:

$ kolibri plugin enable kolibri.plugins.learn

Enabling plugin: kolibri.plugins.learn

Verifying dependencies... OK!
Collecting static assets (JS/CSS/images)........ OK!
Running database migrations............ OK!

Plugin enabled. Please start/restart Kolibri.

from kolibri.

Replacing this issue with #2510

from kolibri.