Code Monkey home page Code Monkey logo

Comments (13)

rtibbles avatar rtibbles commented on July 21, 2024 1

Alas poor kolibri_settings.json, I knew him, Horatio!

from kolibri.

indirectlylit avatar indirectlylit commented on July 21, 2024 1

yup - you can create one yourself, if needed :)

from kolibri.

indirectlylit avatar indirectlylit commented on July 21, 2024

Note - this refers to the ~/.kolibri/kolibri_settings.json file

from kolibri.

indirectlylit avatar indirectlylit commented on July 21, 2024

The main issue here was that the settings file is hard for a developer to manually edit.

As an easier alternative to switching formats, I submitted a quick PR to simply format the JSON in a more developer-friendly way. I think this should suffice to close this issue? (Most devs are familiar with editing JSON)

from kolibri.

benjaoming avatar benjaoming commented on July 21, 2024

Can we re-open this?

I actually liked the unreadable JSON because it avoided people messing around in it with manual edits and writing instructions with references to this file :)

It's nice that the JSON file is readable but there's still no semantic verification or documentation. This means that we're half-encouraging deployments to base things off a configuration file that we don't really support, it's an internal file still.

Being backwards compatible on an interface we didn't intend, can have serious negative consequences.

Ideally, the configuration file is a public, human interface, or it's an un-readable mess that discourages any kind of interaction.

from kolibri.

indirectlylit avatar indirectlylit commented on July 21, 2024

Until #106 is fixed, manually editing the config file is a fairly common activity

from kolibri.

benjaoming avatar benjaoming commented on July 21, 2024

True that! So you're suggesting to fix #106 - I'm stepping up to that!

from kolibri.

indirectlylit avatar indirectlylit commented on July 21, 2024

see also #2019

from kolibri.

benjaoming avatar benjaoming commented on July 21, 2024

#3607

from kolibri.

rtibbles avatar rtibbles commented on July 21, 2024

Shall we close this now, or maybe migrate kolibri_settings.json to an ini file?

from kolibri.

benjaoming avatar benjaoming commented on July 21, 2024

@rtibbles for non-human readable settings it still serves a purpose.. but I guess we don't have any of such? 🎉

I have changed the title of the issue, reduce, reuse, recycle 💚

from kolibri.

indirectlylit avatar indirectlylit commented on July 21, 2024
  • this issue seems to be covered in #2019 and #2510
  • added note about switching from json to ini in #2019
  • also, options.ini now exists

closing to consolidate. let me know if anything wasn't captured

from kolibri.

radinamatic avatar radinamatic commented on July 21, 2024

@indirectlylit

also, options.ini now exists

"Exists" as in is created by default with Kolibri installation, or as in you can create one yourself, if needed? I hope the latter, or I need to amend the documentation.

from kolibri.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.