Code Monkey home page Code Monkey logo

Comments (9)

iskipu avatar iskipu commented on August 23, 2024 1

Hi @AlexVelezLl i dont have my laptop with me as i am out of station, but as far as i remember the grid (div which is flexbox i.e the div containing the cards) has max width of 1700 i believe the screen shot which u shared is the parent div of the flexbox div i was talking about.

If i am wrong u can assign this to @nikkuAg as i will not be having access to my laptop till jan 2nd.

from kolibri.

AlexVelezLl avatar AlexVelezLl commented on August 23, 2024 1

Oh, no rush! Enjoy the holidays! 👐 I'll leave the issue unassigned for whoever can review it first. Hope you have a happy new year!

from kolibri.

iskipu avatar iskipu commented on August 23, 2024 1

the grid does not have a maximum width of 1700

Hi @AlexVelezLl,

image

the grid does have a maximum width of 1700px in Topic/Channel View.

from kolibri.

AlexVelezLl avatar AlexVelezLl commented on August 23, 2024 1

Oh thanks @iskipu, it was my bad, I wasnt selecting the grid div but its parent. I just checked it again and yes, it already has the max-width set 😃. Thank you!

from kolibri.

marcellamaki avatar marcellamaki commented on August 23, 2024 1

@iskipu - no, it's just open because I forgot to close it out. Thanks for checking!

from kolibri.

nikkuAg avatar nikkuAg commented on August 23, 2024

Hey is this issue still open? I would like to work on this

from kolibri.

iskipu avatar iskipu commented on August 23, 2024

Hey is this issue still open? I would like to work on this

Hi @nikkuAg

i don't find any issue with Topic/Channel View and Explore Libraries main view ( refer the comment ) let me know if i am missing something

from kolibri.

AlexVelezLl avatar AlexVelezLl commented on August 23, 2024

Hi @iskipu. I can see that the issue has been solved for the library and explore pages, but I found that when we go to a Topic/Channel View, the grid does not have a maximum width of 1700.

image

I have updated the issue with the completed tasks.

Would you like to take a look at it @iskipu? 😃. Or can I assign the issue to @nikkuAg 👐.

from kolibri.

iskipu avatar iskipu commented on August 23, 2024

Hi @marcellamaki, i think all the issues mentioned are resolved is there any specific reason why this issue is still open ?

from kolibri.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.