ePub and PDF document node icons are the same about kolibri-design-system HOT 10 CLOSED

@khangmach want to find us a new icon and color?

from kolibri-design-system.

Since lessons already uses a book icon, for EPUBS, we could use something like:
https://material.io/tools/icons/?search=chrome&icon=chrome_reader_mode&style=baseline

RE: color
I was thinking about color bloat a while back and was thinking one way we can sort of combat this is to assign colors to various "types" of engagement. Some examples of types of engagement...
One color for Passive engagement -> reading/watching a doc/epub/video
One color for Active engagement -> doing an exercise/interactive html game

We already do this with "inactive" types of engagement by coloring "things you navigate through", (e.g. topics and channel cards) ta dark grey color.

Check out an example with drive. I know we keep linking to drive examples but I think they have their shiz together in this scenario

from kolibri-design-system.

We base icons on the kind at the moment, and both PDFs and EPUBS are 'document' kinds. If the main purpose is to disambiguate the same document presented in two different formats, perhaps they should not be separate content nodes, but the same content node with two different file formats?

from kolibri-design-system.

(in which case we would need a better user flow to support two different file formats being attached to the same content node).

from kolibri-design-system.

perhaps they should not be separate content nodes, but the same content node with two different file formats?

Sounds like more trouble—as there is no precedent for this (multiply primary=True files associated with the same content node) either on Studio or Kolibri.

@rtibbles How hard would it be to update the choosing-the-icon logic to use kind and file format vs. just kind?

from kolibri-design-system.

We mostly insulate the frontend from any consideration of file extensions, the point of content kinds is to have a limited set of 'user interpretable' kinds. Whereas file extensions are a more technical consideration.

What might be better is to have epub be a book type, as opposed to a document type.

from kolibri-design-system.

What might be better is to have epub be a book type, as opposed to a document type.

Yeah this would make more sense. Currently the whole epub and pdf both part of document was fairly confusing on ricecooker + studio side. I propose we continue discussion in January when Jordan is back, but I'm sure she'll be on board with splitting the epub into its own content kind.

Note: doing this switch will require re-running all channels that used epub to switch them to the new convention, but I don't think there were are many of them. Not sure if we'll have to do some backward compatible to things already published...

from kolibri-design-system.

If the main purpose is to disambiguate the same document presented in two different formats, perhaps they should not be separate content nodes, but the same content node with two different file formats?

I agree with this

there is no precedent for this (multiple primary=True files associated with the same content node)

The curator or chef should choose one as being "better" and make it primary, while the other becomes a secondary alternative format.

What might be better is to have epub be a book type, as opposed to a document type.

I think we might eventually need to decouple our implementation details a bit from the user experience:

• Are the African Storybooks no longer 'books' because it's a HTML app?
• Are OER math textbooks no longer 'books' because it's in PDF?
• Is a powerpoint presentation really a 'document' just because it's a PDF?

Some higher-level questions

• What are we actually trying to communicate to users when we label content as a certain kind?
• When are users interested in the render format and learner UX, and when are they interested in the content itself?
• Would we ever allow curators to re-label the kind of content nodes?

from kolibri-design-system.

related: #102

from kolibri-design-system.

Addressed with new 0.15 learner-facing updates

from kolibri-design-system.