Code Monkey home page Code Monkey logo

Comments (8)

le4ker avatar le4ker commented on June 3, 2024

If I'm not wrong, this is the original's grayscale behavior:

http://ironsummitmedia.github.io/startbootstrap-grayscale/

When you scroll through the sections, the navbar highlights the section you are currently viewing.

from personal-jekyll-theme.

veswill3 avatar veswill3 commented on June 3, 2024

It does that as expected but you can end up in a situation where 2 are highlighted at the same time by clicking on one and then scrolling to a different one. The only you clicked will stay lighter and the one you scroll to will activate and highlight as well. If you just grabbed this from somewhere else it may not be your mistake.

from personal-jekyll-theme.

le4ker avatar le4ker commented on June 3, 2024

Yes, the repo that I forked was a mashup of grayscale and agency theme's.

I see what you mean now, I think grayscale theme has a fix for this. I will give it a try to integrate it :)

Thanks!

from personal-jekyll-theme.

le4ker avatar le4ker commented on June 3, 2024

I was able to repro it on http://panossakkos.github.io/personal-jekyll-theme/ and not in http://ironsummitmedia.github.io/startbootstrap-grayscale.

I will have a look at the grayscale css and fix it. Thanks for reporting it! 👍

from personal-jekyll-theme.

joariasl avatar joariasl commented on June 3, 2024

This occur because in the line grayscale.scss:115 the background highlight including to :focus pseudo-class. It is when the object is selected, if you unselect this item this remove the background.
An possible solution is replace this sentence for:

                &:hover,
                &.active {
                    outline: none;
                    background-color: rgba($light, 0.3);
                }
                &:focus {
                    outline: none;
                    background-color: inherit;
                }

from personal-jekyll-theme.

joariasl avatar joariasl commented on June 3, 2024

Other option (Perhaps the best, since it is due to this behavior) is add the line:

$anchor.blur();

in the file grayscale.js after to line 19.

from personal-jekyll-theme.

joariasl avatar joariasl commented on June 3, 2024

In grayscale theme have removed the :focus style. The problem is that this method not indicate the selected item with tab navigation, because :focus selection not have style.
I applied a fix using javascript for focus out after the transition scrolling is ended.

from personal-jekyll-theme.

veswill3 avatar veswill3 commented on June 3, 2024

Awesome. Thanks @PanosSakkos and @joariasl

from personal-jekyll-theme.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.