Code Monkey home page Code Monkey logo

Comments (7)

lcuis avatar lcuis commented on July 29, 2024

Hi @slavap ,

Thanks a lot for raising this important issue.

I didn't realize that the field icons are not on the left when the ‘rightToLeft‘ parameter is set to ‘true‘. They clearly must.

I wish I could correct that now myself but I am on holiday for a few weeks without access to my development hardware.

I wonder whether this behavior should be applied automatically when the app language is RTL because I am not certain the widget text will be as well. This is why I would rather rely on the existing ‘rightToLeft‘ parameter. Does that seem acceptable to you @slavap ?

from search_choices.

slavap avatar slavap commented on July 29, 2024

@lcuis
Yes, for now explicit rightToLeft solves the problem:

SearchChoices.multiple(
      rightToLeft: Directionality.maybeOf(context) == TextDirection.rtl,

But I would say it should be default "automatic" behavior.

from search_choices.

lcuis avatar lcuis commented on July 29, 2024

Thanks for your reply @slavap .

Then I will look into this rtl automatic adaptation as soon as I can.

from search_choices.

slavap avatar slavap commented on July 29, 2024

@lcuis Thank you!

from search_choices.

lcuis avatar lcuis commented on July 29, 2024

Hello @slavap ,

Version 2.2.6 published yesterday should automatically adapt the rtl parameter based on the app.

from search_choices.

slavap avatar slavap commented on July 29, 2024

Yes, it works now by default, thank you.

from search_choices.

lcuis avatar lcuis commented on July 29, 2024

Thanks @slavap for creating the issue, for the solution code and for the confirmation!

from search_choices.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.