Investigate and / or fix 5 failing tests on Android about lbry-android HOT 2 CLOSED

tests.unit.core.test_log_support.TestLogger.test_can_log_failure

09-18 09:18:01.770 16289-16308/io.lbry.lbrynet:service_lbrynet_testrunner I/testrunnerservice: twisted.trial.unittest.FailTest: 'test_log_support.py:18 - My message: terrible things happened' != 'log_support.py:353 - My message: terrible things happened'

The filename and line number mismatch between the expected and actual messages may be happening due to the fact that the tests are loaded as a compiled package on the Android platform.

tests.unit.test_conf.SettingsTest.test_invalid_data_type_raises_exception
KeyError is raised because the "fake_data_type" key is not found in the Config class' _data member. This may also be due to the tests being loaded as a compiled package on the Android platform.

tests.unit.lbrynet_daemon.test_ExchangeRateManager.ExchangeRateTest.test_invalid_rates
tests.unit.test_conf.SettingsTest.test_invalid_setting_raises_exception
The assert statements in the Python code don't seem to be working which results in the corresponding AssertionError not being raised. Proposed fix would be to explicitly check the conditions and raise the AssertionError.

tests.unit.lbrynet_daemon.test_Daemon.TestJsonRpc.test_help
The PYTHONOPTIMIZE flag which is required for the Android build removes docstrings which causes fn.__doc__ to return an invalid value which results in failure.

from lbry-android.

Fixed 3, skipped 2 due to no fix. lbryio/lbry-sdk#940

from lbry-android.