Comments (13)
@ritiksaxena124 Can I work on this issue?
from layer5.
Hey, @Rexford74 and @ritiksaxena124 Can work I on this issue?
from layer5.
@Rexford74 can you explain this issue
from layer5.
@Rexford74 I am interested can you please assign to me as discussed on today's call.
from layer5.
@hargunkaur286, @shailpujan88, @a19hu, and @11happy, Thank you all for your interest in this issue.
@hargunkaur286, can you please confirm if you want to work on this issue? If not, we'll reassign it to the next person in line.
We will proceed in chronological order based on @hargunkaur286's response.
from layer5.
@Ashparshp @Rexford74 for dark mode not available image in figma design
from layer5.
@Ashparshp I'll work on it, can you please assign it to me. Also, the image for dark mode is not available in the figma design file.
from layer5.
@hargunkaur286,
Thanks for taking on the issue! I've assigned it to you. For now, let's focus on implementing the light mode design. We can address the dark mode later.
Let me know if you need any help!
from layer5.
@hargunkaur286 are you working on this issue??
from layer5.
Thank you for helping to assign this issue @Ashparshp. For the Dark Mode questions, I have attached a link to dark mode for both pages.
@hargunkaur286 I'm aware you worked previously on 'Color'. If you faced the same dark mode issue, you can point it out here so that I can give some time for you to implement the dark mode change in the previous PR that you raised. If not I think it's ready to be merged as earlier agreed.
from layer5.
@11happy, I sincerely apologize. I couldn't assign the issue to you as discussed on Wednesday's Meshery call because issues are assigned in the order the requests come in. It's my fault in this case because I hadn't looked at the issue in a while to see that assignment requests had already been made. As a compromise, here is another Meshery issue that has been left unattended for a while now. The previous assignee couldn't get it done and it will be of much help if you can round it off and raise a PR. If you'd like to work on it, kindly drop a comment so I can get you assigned.
Please let me know what you decide @11happy. Thank you for your patience.
from layer5.
@Rexford74 Thank you for updating the figma file, I am working on this issue and will be raising the PR soon. I had no problem in implementing the previous 'color' issue for dark mode, as it already had the required images. You can review that PR. Thanks
from layer5.
Thank you for working on this. I'll take a look and drop a review. Well done!
from layer5.
Related Issues (20)
- [Sistent] Fix the positioning of page section navigator and working HOT 3
- [Sistent] Add a copy button to copy code HOT 3
- [Sistent] Add spacing between the sections HOT 13
- [Sistent] Implement Modal component page HOT 16
- Add spacing on Recognition page HOT 13
- [Events] Feature tag not working as expected HOT 7
- [Sistent] Page Content Update - Color: Code HOT 3
- Update Pricing page content
- Carrers card issue HOT 8
- [Sistent] Code syntax highlighting for sistent components
- [Community] Member Profile: Chris Carrier HOT 10
- [Sistent] Page Content Update: About HOT 10
- [Sisten]: About Sisten Page - Table of content alignment HOT 3
- [MeshMap] Recreate simple drawing and share
- External Link Enhancement
- [Community] Member Profile: Matthieu EVRIN HOT 4
- [Sistent]: Buttons example don't have gap in between HOT 3
- Update ESLint config file to support ESLint v9 HOT 1
- [Community] Member Profile: Dahyeon Kang HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from layer5.