Code Monkey home page Code Monkey logo

Comments (4)

lautis avatar lautis commented on June 5, 2024

Thanks for the bug report, although I believe this is something which needs to be addressed in UglifyJS. You can configure the comma separation using the seqs option, which is by default true.

In your Rails config:

config.assets.js_compressor = Sprockets::LazyCompressor.new {
  require 'uglifier'
  Uglifier.new(seqs: false)
}

I'll keep an eye on this and might change the default in Uglifier if the issue isn't fixed in either UglifyJS or Firefox.

from uglifier.

pvoisin avatar pvoisin commented on June 5, 2024

I'm having the same problem.

@symve - How did it turn out? Have you tried to set seqs false?

from uglifier.

symve avatar symve commented on June 5, 2024

Sorry, I didn't have time to try it out yet. Our JS code changed since, and as a result the problem in our minified code file went away.

from uglifier.

pvoisin avatar pvoisin commented on June 5, 2024

Ahah, I see, we got into the same situation but it came back yesterday... :)

I've just tried it and it seems to solve the problem with very, very little impact on the code size since at the end we're gzipping it anyway.

P.S.: and thanks for posting that issue by the way!

from uglifier.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.