Comments (4)
Sure thing. Sounds good.
On my ideas if it is helpful:
- the one approach is to have a separate async client with the same named methods, but one uses async coroutines and the other has sync methods. Miguel Grindberg does it that way on the
python-socketio
package - see here https://github.com/miguelgrinberg/python-socketio/tree/main/src/socketio. One of the Binance APIs does it this way too - https://github.com/sammchardy/python-binance/blob/master/binance/client.py - Another is to have duplicated methods under the same
EodHistoricalData
object with the async methods prepended withasync_...
or similar. - Another theoretically would be to define sync or async in the constructor of
EodHistoricalData
and that then attaches the sync or async methods as part of that__init__()
. But to me that is less useful as there may be cases where you want to mix async and sync methods.
I think 3 is over-engineered but 1 or 2 works. My personal preference is for 1 as to then move to async all you need to do is change the client.
Hope this helps.
from eod-data.
Hi @ttamg, thank you! Currently, I'm working on the async version, and I'm trying to implement it with the EodHistoricalData
instance to have every single functionality under the same "umbrella." Hopefully, it will be released in conjunction with the new APIs (Tweets Sentiment API and Cryptocurrency Fundamental Data API) during July (version 0.2.1). If you have any idea about implementing the async functionality, it's more than welcome!
I've found a great tutorial on how to contribute, hope it helps.
No, I'm not affiliated in any way with the company EOD. I'm a trader who likes to automate my research and trading strategies. I've contacted the team, and the client is in their documentation, so I'm more than happy with that.
from eod-data.
Thank you very much @ttamg! These are great options. I will check what works best, and hopefully, during Q3 it will be implemented. In the meantime, for July, I will update the Tweets Sentiment API and Cryptocurrency Fundamental Data API.
from eod-data.
Hi @LautaroParada - how are you getting on with thinking about the async option? Let me know if you need some further support. In the meantime threading async support can be provided by people if they use the unsync
library decorator I think.
from eod-data.
Related Issues (10)
- client.get_stock_options() only returns 1 entry per contract HOT 1
- get_instrument_ta() returns error HOT 1
- How can I request only a part of the response when using client.get_search_instrument(query_string=)? HOT 2
- requests.exceptions.HTTPError: 403 Client Error: Forbidden for url: https://eodhistoricaldata.com/api/historical-market-cap/AAPL.US?fmt=json&api_token=APIKEY&from=2020-01-01 HOT 1
- Intraday Commodities and Government Bonds returning empty list HOT 1
- Unusual _ for 'from' parameter HOT 1
- date_range parameter in client.get_bulk_markets(__) method
- User API implementation HOT 1
- Support bulk financials API HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eod-data.