Code Monkey home page Code Monkey logo

Comments (4)

ttamg avatar ttamg commented on July 27, 2024 1

Sure thing. Sounds good.

On my ideas if it is helpful:

  1. the one approach is to have a separate async client with the same named methods, but one uses async coroutines and the other has sync methods. Miguel Grindberg does it that way on the python-socketio package - see here https://github.com/miguelgrinberg/python-socketio/tree/main/src/socketio. One of the Binance APIs does it this way too - https://github.com/sammchardy/python-binance/blob/master/binance/client.py
  2. Another is to have duplicated methods under the same EodHistoricalData object with the async methods prepended with async_... or similar.
  3. Another theoretically would be to define sync or async in the constructor of EodHistoricalData and that then attaches the sync or async methods as part of that __init__(). But to me that is less useful as there may be cases where you want to mix async and sync methods.

I think 3 is over-engineered but 1 or 2 works. My personal preference is for 1 as to then move to async all you need to do is change the client.

Hope this helps.

from eod-data.

LautaroParada avatar LautaroParada commented on July 27, 2024

Hi @ttamg, thank you! Currently, I'm working on the async version, and I'm trying to implement it with the EodHistoricalData instance to have every single functionality under the same "umbrella." Hopefully, it will be released in conjunction with the new APIs (Tweets Sentiment API and Cryptocurrency Fundamental Data API) during July (version 0.2.1). If you have any idea about implementing the async functionality, it's more than welcome!

I've found a great tutorial on how to contribute, hope it helps.

No, I'm not affiliated in any way with the company EOD. I'm a trader who likes to automate my research and trading strategies. I've contacted the team, and the client is in their documentation, so I'm more than happy with that.

from eod-data.

LautaroParada avatar LautaroParada commented on July 27, 2024

Thank you very much @ttamg! These are great options. I will check what works best, and hopefully, during Q3 it will be implemented. In the meantime, for July, I will update the Tweets Sentiment API and Cryptocurrency Fundamental Data API.

from eod-data.

ttamg avatar ttamg commented on July 27, 2024

Hi @LautaroParada - how are you getting on with thinking about the async option? Let me know if you need some further support. In the meantime threading async support can be provided by people if they use the unsync library decorator I think.

from eod-data.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.