Comments (3)
Yep got this as well, seems that if you remove the checks below it works. This code seems to be the culprit. Not sure why it was added. It stops the updated form values from being submitted by using the old values. I think the current form values should just be sent everytime
var expMonthUsed = scope.expMonth ? true : false;
var expYearUsed = scope.expYear ? true : false;
if (!(expMonthUsed && expYearUsed)) {
var exp = Common.parseExpiry(scope.expiry);
scope.expMonth = exp.month;
scope.expYear = exp.year;
}
from angular-payments.
I also agree with @jamesblackwell , the check there is meaningless and should get the new value every time user submit the form.
from angular-payments.
It's been a while since I've looked at this, but if I remember correctly, the check needs to be there in situations where the UI has separate fields for scope.expMonth and scope.expYear. Getting the values from scope.expiry only makes sense if scope.expiry is actually being used.
Changing the lines
scope.expiryMonth = expMonthUsed ? scope.expMonth : null;
scope.expiryYear = expYearUsed ? scope.expMonth : null;
to
scope.expMonth = expMonthUsed ? scope.expMonth : null;
scope.expYear = expYearUsed ? scope.expYear : null;
as in #32 fixes the issue for scope.expiry without breaking the use of scope.expMonth and scope.expYear as individual fields.
from angular-payments.
Related Issues (20)
- Feature request: Validate + Format for address_zip Field
- Specials charachers are allowed in every field
- How to do client side validation and add bootstrap error class?
- error on form submission of invalid API key even though API key has been set
- Card number input error
- Why is the card holder name not sent to stripe? HOT 1
- Specific $scope bindings HOT 2
- Creating Charges HOT 1
- Supporting Google pay?
- Masked inputs are not working in mobile devices HOT 2
- blank screen on the iphone when using angular-payments HOT 3
- what after getting the stripeToken ? HOT 1
- address_line1_check & address_zip_check #81 HOT 1
- "Cannot read property 'apply' of undefined" HOT 1
- Repo in active development ? HOT 2
- attributes is not defined at angular-payments.js
- payments-format="expiry" Invalid Date issue HOT 3
- Calling the stripe-form directive method from a controller (or another directive) HOT 1
- Backspace on CVC field not working after 4 digits on Firefox HOT 5
- Make Editing error messages so obvious. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angular-payments.