Code Monkey home page Code Monkey logo

Comments (3)

jamesblackwell avatar jamesblackwell commented on May 18, 2024

Yep got this as well, seems that if you remove the checks below it works. This code seems to be the culprit. Not sure why it was added. It stops the updated form values from being submitted by using the old values. I think the current form values should just be sent everytime

                    var expMonthUsed = scope.expMonth ? true : false;
                    var expYearUsed = scope.expYear ? true : false;

                    if (!(expMonthUsed && expYearUsed)) {
                        var exp = Common.parseExpiry(scope.expiry);
                        scope.expMonth = exp.month;
                        scope.expYear = exp.year;
                    }

from angular-payments.

siygle avatar siygle commented on May 18, 2024

I also agree with @jamesblackwell , the check there is meaningless and should get the new value every time user submit the form.

from angular-payments.

anthonypleshek avatar anthonypleshek commented on May 18, 2024

It's been a while since I've looked at this, but if I remember correctly, the check needs to be there in situations where the UI has separate fields for scope.expMonth and scope.expYear. Getting the values from scope.expiry only makes sense if scope.expiry is actually being used.

Changing the lines

scope.expiryMonth = expMonthUsed ? scope.expMonth : null;
scope.expiryYear = expYearUsed ? scope.expMonth : null;

to

scope.expMonth = expMonthUsed ? scope.expMonth : null;
scope.expYear = expYearUsed ? scope.expYear : null;

as in #32 fixes the issue for scope.expiry without breaking the use of scope.expMonth and scope.expYear as individual fields.

from angular-payments.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.