Global limit and routes setting a limit cause double response headers about slowapi HOT 8 OPEN

I've been able to reproduce the issue in a test, but haven't had time to put together a complete fix. I'm not far off, I'll try to finish it over the weekend.

from slowapi.

Further investigation it seems the issue only appears when using a custom method to return the limit, but does not happen when using a string.

from slowapi.

The custom method to return a rate limit is simply:

def get_user_rate_limit() -> str:
    return "100/1 day"

So nothing fancy there. If I simply use a string on the limit decorator everything works as I would expect.

from slowapi.

anyone else experiencing this issue?

from slowapi.

@laurentS still happening for me

from slowapi.

@laurentS Did you manage to get a fix for this?

Its causing some weird behaviour around the slowapi/extension.__limit_decorator:async_wrapper where the second request comes through as None throwing:

  File "D:\programming\financefeast_api\venv\lib\site-packages\slowapi\extension.py", line 622, in async_wrapper
    raise Exception(
Exception: parameter `request` must be an instance of starlette.requests.Request

from slowapi.

@papapumpnz no, sorry. I haven't found time to work on this any further. It would probably help if you could provide a couple of test cases that reproduce the error(s) you see (and the cases where you don't see an error).

from slowapi.

Ok @laurentS forked and have a new test suite called test_double_headers that produces double headers, or single headers. Difference is the limiter decorator uses either a callable (produces double headers) or a string (produces single headers).

from slowapi.