Question: old deconjugator about spark-reader HOT 2 CLOSED

If the old deconjugator works with your updated ValidWord/StdRule classes, then there should be no reason to add a duplicate that does the same thing. Perhaps the parts of the code you didn't change could be left in a 'new' old StdRule and you can extend and override that to add your extra features, but that's not really important if it isn't needed.

I tend to make code that works first, then redo it later for speed and neatness when needed, so I'm fine with it being a bit of a mess at first.

I'm planning to release 0.6 soon so I can get some feedback on the new basic Epwing support. After that, when you're ready, you can add your changes to the main branch. I think I can add you to the main repository as well so you can make improvements after it's been added, I'll look into trying that.

from spark-reader.

Yeah, sounds like the new tests are good then.

I don't badly need commit access even once the new deconjugator is added, PRs are how I'm used to doing things even with a game I worked on for a while, but we'll see how it goes.

from spark-reader.