Comments (6)
I'm actually a little surprised by the silence here. I know Pullup has gotten slow, but I didn't realize it was this bad...
Anyways, I don't actually know about these permissions myself. I've been logged into the site for months and I don't think I've been pestered about it at all. I just checked the permissions for my account and it doesn't appear to have changed.
My first PR was accepted just a few weeks after yours, so I'm not sure what could have changed between when you signed up and when I did.
from pullup.
After looking through the commits between yours and mine, I found this commit that might explain why it needs the extra permissions. Basically, Pullup uses your user to pull data about Pullup from GitHub if you're logged in.
This may have been changed later, but it might explain the permissions.
EDIT: I also found this commit which allows users to comment on GitHub issues through the website. In retrospect, I probably should have remembered this one, since I've used it before. I don't know much about GitHub's app permissions, but I do agree that, even with this, it seems like we might have made the requested permissions a bit more than what we actually need.
from pullup.
@josephwegner @megamattron any idea why we're requiring these permissions?
from pullup.
I'm fairly certain that when Pulluo was originally written, Github only had
one permissions level.
That is no longer the case, so we can probably lighten the requirements.
from pullup.
That would explain it. Looks like we're requesting the public_repo
scope here, which requires:
Grants read/write access to code, commit statuses, collaborators, and deployment statuses for public repositories and organizations. Also required for starring public repositories.
from pullup.
We only need user:email
. I've removed public_repo
from the scopes in #384.
from pullup.
Related Issues (20)
- Footer is not anchored to the bottom of the page HOT 5
- Better mobile views HOT 1
- Consider having a goal to focus on. HOT 4
- Landing page still visible after login HOT 1
- A new idea for PullUp HOT 16
- Help: Issue deploying to heroku HOT 2
- Autocomplete username in comments HOT 3
- Update README.md: no need to include quotes around env variables when exporting them HOT 1
- Pullup as a reddit style layer for pull requests and issues. HOT 8
- [RFC] Switch from Gitter to Slack
- [LINKS] Domain not parsed on this submission HOT 1
- [PROFILE] Add contributions to mobile
- Add margin between error message and join alert HOT 2
- Make comments linkable
- Submit News button is misaligned HOT 3
- Hide upvote button if already upvoted
- On mobile: Vertically center vote count when there's no upvote
- Comment deleting needs a backend check
- Help me
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pullup.