Comments (2)
I see. It could a good option and strict
is I think the good argument name.
However, it should be generalized to each tidy_*
functions.
- tidy_identify_variables(): check if variable names has been found. If it is not the case, var_type will be "unknown".
- tidy_add_contrasts(): check, if there are categorical variables only, that a contrasts value has been documented. Do we have a case where it will fail?
- tidy_add_reference_rows(): all categorical variables with a treatment, SAS or sum contrasts should have a reference row. Not sure if there is a case where it will fail.
and so on....
A difficulty is to identify cases where it will fail to develop the appropriate tests.
Not sure to have enough time this week but if you want to explore and to propose a PR, you are welcome
from broom.helpers.
I like adding the strict argument for tidy_identify_variables()
and tidy_add_header_rows(show_single_row=)
because the user is specifically asking for something that can result in an error.
For tidy_add_contrasts()
I would only make it an error if there was a categorical variable that should have a contrast and it cannot be addressed.
For tidy_add_reference_rows()
I would only make it an error if there was a categorical variable that should have a reference row that we cannot add.
I'll work on a PR.
from broom.helpers.
Related Issues (20)
- Required change to stay on CRAN
- Release broom.helpers version 1.14.0
- Support for mmrm models HOT 8
- Support for MASS::contr.sdif() contrasts
- Support for zero-inflated models
- beta regression is not supported yet HOT 2
- Considering a `tidy_post_fun` argument to `tidy_plus_plus()` HOT 2
- Support with coxphf model HOT 9
- Bug fixes and improvements for mixed models HOT 1
- tbl_regression (package gtsummary) and ggcoef_model (package ggstats) not working on the output of a replicate svyglm model HOT 2
- fantastic support of multivariate quantile regression for any quantile HOT 1
- Support for survival::cch model? HOT 5
- Avg_comparisons and nlme::lme() models HOT 1
- order of variable levels with marginal tidiers HOT 8
- Release broom.helpers 1.15.0
- Take into account (id) when computing model_get_n() for coxph models
- `marginaleffects::datagridcf()` is deprecated
- Do you know the status of the {margins} pkg? HOT 1
- Explore better support of VGAM::vglm() models
- Execution time
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from broom.helpers.