Code Monkey home page Code Monkey logo

Comments (2)

larmarange avatar larmarange commented on July 1, 2024

I see. It could a good option and strict is I think the good argument name.
However, it should be generalized to each tidy_* functions.

  • tidy_identify_variables(): check if variable names has been found. If it is not the case, var_type will be "unknown".
  • tidy_add_contrasts(): check, if there are categorical variables only, that a contrasts value has been documented. Do we have a case where it will fail?
  • tidy_add_reference_rows(): all categorical variables with a treatment, SAS or sum contrasts should have a reference row. Not sure if there is a case where it will fail.

and so on....

A difficulty is to identify cases where it will fail to develop the appropriate tests.

Not sure to have enough time this week but if you want to explore and to propose a PR, you are welcome

from broom.helpers.

ddsjoberg avatar ddsjoberg commented on July 1, 2024

I like adding the strict argument for tidy_identify_variables() and tidy_add_header_rows(show_single_row=) because the user is specifically asking for something that can result in an error.

For tidy_add_contrasts() I would only make it an error if there was a categorical variable that should have a contrast and it cannot be addressed.

For tidy_add_reference_rows() I would only make it an error if there was a categorical variable that should have a reference row that we cannot add.

I'll work on a PR.

from broom.helpers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.