Code Monkey home page Code Monkey logo

Comments (7)

MegaIng avatar MegaIng commented on June 1, 2024

Considering that v_args(meta=True) is being tested with the order meta, items, and those tests still pass, I don't think that changed:

def ab_method(self, meta, children):

Not sure what you mean with the rename?

Are you sure you are actually looking at 1.1.7? Both of these changes are stuff from pre-1.0.0

from lark.

akissinger avatar akissinger commented on June 1, 2024

Having uninstalled 1.1.5 and installed 1.1.7 again, I can't reproduce the argument order problem, so maybe something funny happened with my pip version locally. If that's the case, the only problems seem to be the reference to ParseTree here: https://lark-parser.readthedocs.io/en/stable/classes.html#lark.Lark.parse (n.b. this is listed as the return type of parse, but it seems to be called Tree now) and the fact that the docs aren't building on ReadTheDocs.

from lark.

MegaIng avatar MegaIng commented on June 1, 2024

No, ParseTree is correct there. It's an alias for Tree['Token'].

from lark.

akissinger avatar akissinger commented on June 1, 2024

Ah! I found it. I had this (I guess defunct?) package installed in my global site_packages:

https://pypi.org/project/lark-parser/

It's a bit confusing that the readthedocs project is called lark-parser but on pypi its lark. I guess this is because lark was already taken. I don't know if it's possible/desirable to take the pypi lark-parser offline, or at least warn people not to use it.

from lark.

erezsh avatar erezsh commented on June 1, 2024

I don't want to take lark-parser offline from pypi, because it might break existing projects that use an old version. However, we don't publish any new packages there. What sort of warning do you think I should place, and where?

Yes, https://lark.readthedocs.io/ is occupied by an unmaintained project.

@MegaIng IIRC he willingly relinquished lark on PyPI. Perhaps we can ask him to do the same with readthedocs?

from lark.

MegaIng avatar MegaIng commented on June 1, 2024

Yeah, we should ask.

from lark.

akissinger avatar akissinger commented on June 1, 2024

Perhaps you could publish a final version under lark-parser that either issues a deprecation warning whenever the module is imported or is just a stub depending on the latest version of lark. There seem to be some reasonable suggestions in this article:

https://www.dampfkraft.com/code/how-to-deprecate-a-pypi-package.html

People should be able to keep the old behaviour if they depend on lark-parser==0.12.0.

from lark.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.