Eager loading not possible about cashier-paddle HOT 3 CLOSED

Hi there,

Thanks for reporting but it looks like this is a question which can be asked on a support channel. Please only use this issue tracker for reporting bugs with the library itself. If you have a question on how to use functionality provided by this repo you can try one of the following channels:

• Laracasts Forums
• Laravel.io Forums
• StackOverflow
• Discord
• Larachat
• IRC

However, this issue will not be locked and everyone is still free to discuss solutions to your problem!

Thanks.

from cashier-paddle.

@driesvints Hi Dries.

I'm starting to think this is actually a package issue.

The amount of duplicate queries drops from 8 to 0 when making the following change. (line)

$this->subscriptions()->where('name', $name)->first();

$this->subscriptions->where('name', $name)->first();

This is also how it is done in the Stripe version of Cashier. (line)

/**
 * Get a subscription instance by name.
 *
 * @param  string  $name
 * @return \Laravel\Cashier\Subscription|null
 */
public function subscription($name = 'default')
{
    return $this->subscriptions->sortByDesc(function (Subscription $subscription) {
        return $subscription->created_at->getTimestamp();
    })->first(function (Subscription $subscription) use ($name) {
        return $subscription->name === $name;
    });
}

By using the function you always access the relationship and make a new query instead of accessing the previously loaded results.

Could you confirm this isn't a bug?

I took the liberty to create a PR so this can quickly be resolved in case you agree with me.

from cashier-paddle.

Hey Yoeri. Your change would load all subscriptions into memory and do the where clause on the collection rather than the query builder. This would raise its own sets of problems (see Taylor's response on your PR).

I think the code in Cashier Stripe is for legacy purposes but not entirely sure. I'm attempting a PR to simplify it in Cashier Stripe: laravel/cashier-stripe#1002

from cashier-paddle.