Code Monkey home page Code Monkey logo

Comments (9)

GertTimmerman avatar GertTimmerman commented on June 3, 2024 2

@sandervanhooft i was not able to respond yesterday, but i have tested it and is works like it should work, the issue not occurs anymore. Thanks for the fix!

from cashier-mollie.

MSnoeren avatar MSnoeren commented on June 3, 2024 1

This is still happening on the latest version. I just got it too. I've had this issue for months but simply fixed it by adding the tax method to the billable model. That's also the reason why I forgot to report it...

from cashier-mollie.

sandervanhooft avatar sandervanhooft commented on June 3, 2024

Hi @GertTimmerman ,

Thanks for trying out the package and reporting this issue.

At first glance I'd say there's an issue in the handler Laravel\Cashier\FirstPayment\Actions\StartSubscription.

I'll look into this further, feel free to join.

from cashier-mollie.

sandervanhooft avatar sandervanhooft commented on June 3, 2024

The array_filter method is causing the issue, filtering out any pairs with a 0 value.

from cashier-mollie.

sandervanhooft avatar sandervanhooft commented on June 3, 2024

Scratch that, that would be fine with value 21.

Not sure yet what's going on. Can you double check this is the correct payment id?

from cashier-mollie.

sandervanhooft avatar sandervanhooft commented on June 3, 2024

Also, can you try upgrading to v0.1.1 (released this afternoon), so we're on the same page?

from cashier-mollie.

sandervanhooft avatar sandervanhooft commented on June 3, 2024

It doesn’t explain why it’s happening in the case of @GertTimmerman, who has implemented the same method and uses a 21 value.

I do have prepared a PR fixing the zero tax issue, but I can’t reproduce the one this ticket was opened for yet.

from cashier-mollie.

sandervanhooft avatar sandervanhooft commented on June 3, 2024

I've released v0.1.2 just now, fixing the 0 tax percentage issue.

@GertTimmerman can you check if the issue still occurs with a non-zero tax percentage?

from cashier-mollie.

sandervanhooft avatar sandervanhooft commented on June 3, 2024

Thanks @GertTimmerman !

from cashier-mollie.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.