Code Monkey home page Code Monkey logo

Comments (7)

DarkaOnLine avatar DarkaOnLine commented on May 30, 2024

I just tested JCB card number and it passes validation

from credit-card.

cesarureno avatar cesarureno commented on May 30, 2024

I got this message
screen shot 2018-05-29 at 02 54 33

from credit-card.

DarkaOnLine avatar DarkaOnLine commented on May 30, 2024

It's failing due to the spaces. Will release fix

from credit-card.

DarkaOnLine avatar DarkaOnLine commented on May 30, 2024

hmmm, I do not know if it's correct to trim all spaces before validation. Does stripe or other providers except credit card numbers with spaces?

from credit-card.

cesarureno avatar cesarureno commented on May 30, 2024

VISA card is working good, even with the space
screen shot 2018-05-29 at 03 20 01

from credit-card.

DarkaOnLine avatar DarkaOnLine commented on May 30, 2024

Its really strange, we even have this card number in our tests and it's passing: https://github.com/laravel-validation-rules/credit-card/blob/master/tests/Unit/Cards/JcbTest.php#L19

from credit-card.

cesarureno avatar cesarureno commented on May 30, 2024

I have decided to eliminate the spaces before validating and everything works perfect, thank you very much

from credit-card.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.