Code Monkey home page Code Monkey logo

Comments (7)

freekmurze avatar freekmurze commented on July 22, 2024 1

Great! Big thumbs up for those integration tests!

from pushover.

casperboone avatar casperboone commented on July 22, 2024

@freekmurze Ready :)

from pushover.

freekmurze avatar freekmurze commented on July 22, 2024

Ok, hold off from making commits for the coming half hour.

from pushover.

freekmurze avatar freekmurze commented on July 22, 2024

Ok, I made some changes, nothing big, all details.

However the tests seems to fail. You'll need to use something like orchestra/testbench to make 'm pass on Travis.

from pushover.

casperboone avatar casperboone commented on July 22, 2024

Thanks! Made one comment, 3eae0e7#commitcomment-18624165, but agree with everything else.

Will look into the tests, was only running them in a Laravel app until now ;).

from pushover.

casperboone avatar casperboone commented on July 22, 2024

Fixed the tests.

from pushover.

casperboone avatar casperboone commented on July 22, 2024

Thanks :)

from pushover.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.