[Bug] Cannot run "php artisan backpack:crud bug" working with Bug.php model about generators HOT 10 CLOSED

@dividy could you check if #100 fixes it?

Best,
Pedro

from generators.

I was about to submit this :

$file_array = preg_split('/\r\n|\r|\n/', $file);

Beat me to it 😄

Your PR works 👍

Model already exists! We just added CrudTrait on it.
Request already exists!
Route already exists!
Sidebar item already exists!

from generators.

Hello there! Thanks for opening your first issue on this repo!

Just a heads-up: Here at Backpack we use Github Issues only for tracking bugs. Talk about new features is also acceptable. This helps a lot in keeping our focus on improving Backpack. If you issue is not a bug/feature, please help us out by closing the issue yourself and posting in the appropriate medium (see below). If you're not sure where it fits, it's ok, a community member will probably reply to help you with that.

Backpack communication mediums:

• Bug Reports, Feature Requests - Github Issues (here);
• Quick help (How do I do X) - Gitter Chatroom;
• Long questions (I have done X and Y and it won't do Z wtf) - Stackoverflow, using the backpack-for-laravel tag;

Please keep in mind Backpack offers no official / paid support. Whatever help you receive here, on Gitter, Slack or Stackoverflow is thanks to our awesome awesome community members, who give up some of their time to help their peers. If you want to join our community, just start pitching in. We take pride in being a welcoming bunch.

Thank you!

--
Justin Case
The Backpack Robot

from generators.

Hello @IazLur

Thanks for the bug report.

I just transfered your issue to the correct repository.

Could you please provide some more info with: php artisan backpack:version and gives us info what version of generators you are loading in your composer.json ?

Thanks in advance,
Pedro

from generators.

PHP VERSION:

PHP 7.3.12 (cli) (built: Nov 19 2019 13:58:02) ( ZTS MSVC15 (Visual C++ 2017) x64 )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.12, Copyright (c) 1998-2018 Zend Technologies

LARAVEL VERSION:

v8.6.0@a71952a6dba55de0bb11b5fbbd84874eda2a755c

BACKPACK VERSION:

4.1.25@23fb1ed5153d5465d49d2fe1ca265a5985c78877

"require-dev": {
"backpack/generators": "^3.1",
"facade/ignition": "^2.3.6",
"fzaninotto/faker": "^1.9.1",
"laracasts/generators": "^2.0",
"mockery/mockery": "^1.3.1",
"nunomaduro/collision": "^5.0",
"phpunit/phpunit": "^9.3"
},

@pxpm

from generators.

Hmm that's weird. It worked fine for me:

@IazLur by any chance did you already have a Bug.php model? If so, we're going to need the code inside Bug.php BEFORE Backpack made any changes to it, to detect what the problem was... What happens is the Backpack tries in this case to add use the CrudTrait inside your existing model. But, depending on how your model is coded, it might fail in some very particular cases. We just need to understand what that particular case is 😄

from generators.

Hi, I tried to understand where was the bug but I didn't found.
Here is the Bug.php before I made the command.

`<?php

namespace App\Models;

use Illuminate\Database\Eloquent\Factories\HasFactory;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Relations\HasMany;
use Illuminate\Database\Eloquent\Relations\HasOne;
use Illuminate\Database\Eloquent\Relations\BelongsTo;;

class Bug extends Model
{
use HasFactory;

/**
 * @var string
 */
protected $table = 'bugs';

/**
 * @var array
 */
protected $guarded = [];

/**
 * @return BelongsTo
 */
protected function bugGame()
{
    return $this->belongsTo(BugGame::class);
}

/**
 * @return HasMany
 */
protected function bugMedias()
{
    return $this->hasMany(BugMedia::class);
}

/**
 * @return BelongsTo
 */
protected function bugType()
{
    return $this->belongsTo(BugType::class);
}

/**
 * @return BelongsTo
 */
protected function gameVersion()
{
    return $this->belongsTo(GameVersion::class);
}

}`

from generators.

Your model already exists.

Remove it and try again the command.

from generators.

On my side, the bug seems to be with the file being read as 1 big line.

Problem might be here :

$file_array = explode(PHP_EOL, $file);

from generators.

Thanks guys!

The PR was merged and tagged, a composer update should fix it (by getting backpack/generators 3.1.4). So let's close this.

Cheers!

from generators.