dyn_stack problem with Option<MenuDisplay> about floem HOT 5 CLOSED

https://github.com/lapce/floem/blob/936e5ce26efaef9a9ab2c8f6fce3bfe09f9a2c21/src/window_handle.rs#L1392C20-L1398C22

Looks like this part of the code should use an atomicu32 for key function instead of doing s.clone().

The clone is problematic because the separator items will hash the same so as soon as there is more than one the dyn stack will have the count wrong. Unique values are needed

from floem.

f for enter misclick 😮‍💨

I fixed it by changing menu display to enum

    #[derive(Clone, PartialEq, Eq, Hash)]
    pub enum MenuDisplay {
        Separator(usize),
        Item {
            id: Option<u64>,
            enabled: bool,
            title: String,
            children: Option<Vec<MenuDisplay>>,
        },
    }

separator is is given at format_menu

    fn format_menu(menu: &Menu) -> Vec<MenuDisplay> {
        menu.children
            .iter()
            .enumerate()
            .map(|(sep, e)| match e {
                crate::menu::MenuEntry::Separator => MenuDisplay::Separator(sep),

from floem.

Could also make MenuEntry::Separator to have id from static AtomicU64 when its added to Menu but dunno if that's necessary, index from iterator should be unique enough?

I can make PR, whatever you think is better?

from floem.

The enum looks like a good solution to me. @dzhou121 ?

from floem.

Made a pr

from floem.