Visual regression on virtual list? about floem HOT 7 CLOSED

You probably implicitly changed from virtual_stack to virtual_list?

from floem.

I will have a proper look tonight after work, but this example seems to be using the same VirtualDirection and VirtualItemList I am:

I might be missing something so I'll do an in-depth comparison.

from floem.

Did the semantics of the item_size parameter change by any chance? I might have unknowingly been relying on a bug to lay out my radio buttons horizontally. Previously, even with item_size VirtualListItemSize::Fixed(Box::new(|| 1.0)) and a very long radio group button label, there was no overlap:

The reason I started using virtual_list for this was to lay out a dynamic number of items horizontally. My use case is a generic radio group widget that takes an enum and renders all its options by relying on the Display trait.

from floem.

Ah indeed, I need to use virtual_stack from now on:

from floem.

It's probably a layout issue with horizontal virtual_lists.

You do have to correctly specify item sizes however, so you probably want to use h_stack_from_iter if you can't do that.

from floem.

Having replaced virtual_list with virtual_stack, I'm still seeing a subtle difference. It looks like the .gap(0.0, 20.0)) in the parent v_stack collapses in the new version:

Old Floem version with virtual_list:

New Floem version with virtual_stack:

Diff available here.

from floem.

@Zoxc Our comments crossed, I'll give that a try - thanks!

from floem.