Comments (7)
I've started tinkering with a refactor along the lines of what I mentioned in #28. It should also address #31. You can see it over in my central_finder branch.
It's only a beginning, but seems to work. I'm still working out how best to integrate the pylint tool, since that one works quite a bit differently than the rest.
from prospector.
@jayclassless thanks for the prompt update, I'll give the https://github.com/jayclassless/prospector/commits/central_finder branch a look and post comments. Do you want the branch feedback on this ticket @jayclassless
from prospector.
@jayclassless great stuff. Most of the tools are very similar (and from the same author, the awesome @florentx) but pylint is a different beast. Pylint has always needed special case workarounds to manipulate it, so feel free to make some extra configuration that only applies to pylint. The point of prospector, after all, is to bring these tools together in a consistent manner and hide the complexity (as much as possible) from the end user!
from prospector.
Also be aware that pylint fiddles with sys.path
to help it inspect the imported classes. The current file-finding logic also needs to return a list of directories to append to the path to enable pylint to function correctly.
from prospector.
It may be desirable to add the ability to silence the pylint import check logic, if possible, given that it doesn't work when inspecting code run in a virtualenv from outside the virtualenv as is the case when used as part of an IDE or editor plugin. Upside is it would make the sys path stuff less integral to using pylint as part of prospector.
Sent from Molto for iPad
From: carlio
Sent: Tuesday, July 08, 2014 01:12 am
To: landscapeio/prospector
Cc: Samuel Bishop
Subject: Re: [prospector] More powerful inclusion/exclusion configuration (#26)
Also be aware that pylint fiddles with sys.path to help it inspect the imported classes. The current file-finding logic also needs to return a list of directories to append to the path to enable pylint to function correctly.
—
Reply to this email directly or view it on GitHub.
from prospector.
@jayclassless I ended up rolling my own as it was a little urgent given this issue: landscapeio/landscape-issues#70 - turns out that frosted (and probably others) were not using exclusion logic correctly!
from prospector.
Ah, cool. Sorry I never got around to finishing what I had started -- endless distractions kept me away.
Hopefully this will kill off the bugs we keep running into with this stuff.
from prospector.
Related Issues (20)
- [BUG]Cannot run tool bandit as support was not installed. HOT 4
- [BUG] Mypy is described as experimental when it's now stable HOT 1
- [BUG] prospector2 won't install on Windows apparently since using forward slash instead of os.path.join HOT 1
- Prospector 1.10.2 does not support `with_mypy` optional tool [in conda] HOT 5
- [BUG] prospector fails when pyproject.toml contain multiple constraints dependencies
- [FEATURE REQUEST] MyPy check-untyped-defs option.
- [BUG] Incorrect additional_dependencies documentation to run prospector as a pre-commit hook with mypy support HOT 2
- [BUG] toml support is incomplete HOT 1
- [PKG SUPPORT] `pylint <3` and Python 3.12 HOT 11
- [PKG SUPPORT] changes for support of `flake >=6.0.0` (and Python 3.12, implicit) HOT 3
- [BUG] pre-commit hook fails on Python 3.12 because of deprecated pkg_resources HOT 3
- [BUG] False positive E231 error in pycodestyle HOT 3
- [BUG] Fatal error pylint: astroid-error HOT 1
- [FEATURE REQUEST] How to use `prospector` on a string
- [BUG] missing dependency: setuptools HOT 1
- [BUG] Crash with ValueError HOT 1
- [BUG] prospector fails with UnicodeDecodeError on requirements.txt having DOS (CRLF) line endings HOT 2
- [BUG] `prospector[with_pyroma]` not appearing to install pyroma when creating conda environments
- [FEATURE REQUEST] Baseline generation
- [BUG] Strange errors with python version 3.12.3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prospector.