Expr arithmetic and comparisons working differently, inconsistent errors about toybox HOT 3 OPEN

no, it's not you... this fixes it:

diff --git a/toys/pending/expr.c b/toys/pending/expr.c
index a236aaab..54ebd14b 100644
--- a/toys/pending/expr.c
+++ b/toys/pending/expr.c
@@ -146,9 +146,8 @@ static struct op_def {
 
 void eval_op(struct op_def *o, struct value *ret, struct value *rhs)
 {
-  long long a, b, x = 0; // x = a OP b for ints.
+  long long cmp, a, b, x = 0; // x = a OP b for ints.
   char *s, *t; // string operands
-  int cmp;
 
   switch (o->sig) {
 

but i think rob's rewriting expr right now anyway?

from toybox.

Great, thanks!
Does this also solve the issue with the inconsistent return codes? Because I am still not sure what they were caused by.

from toybox.

Commit 251be88 with a test.

As for rewrite, I have a tree with a dirty expr.c in it but it doesn't collapse cleanly into the $(( )) math logic and I find a lot of its string vs not string behavior non-obvious, so I keep waffling over throw it out vs patch what's there vs try not to touch it...

from toybox.