Comments (8)
Pull requests are more than welcome, the documentation only shows examples
for EJS and Jade, that is kind of obvious it's only for EJS and Jade... but
I'd really like to see Handlebars integrated as I know others probably
could benefit from it. Thank you.
On Fri, Feb 28, 2014 at 4:01 PM, Michael Phillips
[email protected]:
I'm wondering what the recommended method of integration into
handlebars.js http://handlebarsjs.com/ is. The examples outlined in the
README.md only outline implementations in Jade and EJS, but my site uses
Handlebars templates. I see that on this line:
https://github.com/niftylettuce/express-cdn/blob/master/lib/main.js#L514,
you reference only two valid extensions - does this mean there isn't
support for any templating language other than these two? If so, this
should be made explicit in the README.mdReply to this email directly or view it on GitHubhttps://github.com//issues/63
.
from express-cdn.
I see you started working on this already, can't wait to accept your PR, thanks @createbang!
from express-cdn.
I'm not sure I agree that the presence of two examples means that those are the only two ways something can work. Anyway, I do have a PR in the works for this, with an updated README.md
to include compatible templating languages.
from express-cdn.
perfect
On Sat, Mar 1, 2014 at 10:57 AM, Michael Phillips
[email protected]:
I'm not sure I agree that the presence of two examples means that those
are the only two ways something can work. Anyway, I do have a PR in the
works for this, with an updated README.md to include compatible
templating languages.Reply to this email directly or view it on GitHubhttps://github.com//issues/63#issuecomment-36428168
.
from express-cdn.
@createbang hows the PR?
from express-cdn.
@niftylettuce it's basically done, but I want to clean some things up and also expose some handlebars helpers in the examples. Hopefully soon.
from express-cdn.
Hi guys, just checking in on this? Really keen for hbs support :)
from express-cdn.
@niftylettuce: Was this done? Is handlebars supported? 🤞
from express-cdn.
Related Issues (20)
- Express CDN doesn't support video/mp4
- Error when installing express-cdn HOT 2
- Error during install on node 6 due to outdated optipng-bin and jpegtran-bin dependencies HOT 2
- Files do not upload to s3 HOT 2
- BUG : removing the first character of file path HOT 1
- production true is giving errors
- Action required: Greenkeeper could not be activated 🚨
- When Uglify fails, it doesn't tell which file is failing it. HOT 1
- Older version of clean-css leaving truncated files HOT 1
- Error: TypeError: assets.substr is not a function
- Getting error after latest update HOT 2
- File file.js comes to S3 without content. HOT 2
- 0.31 and 0.32 releases are broken by UglifyJS 3.X HOT 2
- In package.json update dependency on 'request' module to 2.88.0
- BUG: timestamp cache not set properly
- Concatenating files doesn't produce a URL-encoded CDN address HOT 2
- Working with vars
- Explicitly define list of assets HOT 1
- Private bucket support
- Asset versioning in production HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from express-cdn.