Support for Handlebars.js about express-cdn HOT 8 CLOSED

Pull requests are more than welcome, the documentation only shows examples
for EJS and Jade, that is kind of obvious it's only for EJS and Jade... but
I'd really like to see Handlebars integrated as I know others probably
could benefit from it. Thank you.

On Fri, Feb 28, 2014 at 4:01 PM, Michael Phillips
[email protected]:

I'm wondering what the recommended method of integration into
handlebars.js http://handlebarsjs.com/ is. The examples outlined in the
README.md only outline implementations in Jade and EJS, but my site uses
Handlebars templates. I see that on this line:
https://github.com/niftylettuce/express-cdn/blob/master/lib/main.js#L514,
you reference only two valid extensions - does this mean there isn't
support for any templating language other than these two? If so, this
should be made explicit in the README.md

Reply to this email directly or view it on GitHubhttps://github.com//issues/63
.

from express-cdn.

I see you started working on this already, can't wait to accept your PR, thanks @createbang!

from express-cdn.

I'm not sure I agree that the presence of two examples means that those are the only two ways something can work. Anyway, I do have a PR in the works for this, with an updated README.md to include compatible templating languages.

from express-cdn.

perfect

On Sat, Mar 1, 2014 at 10:57 AM, Michael Phillips
[email protected]:

I'm not sure I agree that the presence of two examples means that those
are the only two ways something can work. Anyway, I do have a PR in the
works for this, with an updated README.md to include compatible
templating languages.

Reply to this email directly or view it on GitHubhttps://github.com//issues/63#issuecomment-36428168
.

from express-cdn.

@createbang hows the PR?

from express-cdn.

@niftylettuce it's basically done, but I want to clean some things up and also expose some handlebars helpers in the examples. Hopefully soon.

from express-cdn.

Hi guys, just checking in on this? Really keen for hbs support :)

from express-cdn.

@niftylettuce: Was this done? Is handlebars supported? 🤞

from express-cdn.