Code Monkey home page Code Monkey logo

Comments (6)

L-Blondy avatar L-Blondy commented on June 14, 2024

It would either break with nested themes or produce a huge amount of css. See this thread for more details.

It would be interesting to see your use case for variants, can you share some code snippet?

from tw-colors.

ninox14 avatar ninox14 commented on June 14, 2024

My potential use case is for UI components kit that has different themes
The theme selected for the application and all components adhere to it

<html className="theme-two">
  <button className="rounded text-primary theme-two:rounded-lg theme-two:font-medium" />
  <input className="rounded text-secondary theme-two:rounded-lg theme-two:font-thin" />
</html>

Does it make sense?

from tw-colors.

L-Blondy avatar L-Blondy commented on June 14, 2024

Makes perfect sense indeed.

If your use case is for a UI library and you don't care about nested themes, you probably want to make some tailwind components anyways. It might look something like this:

const plugin = require('tailwindcss/plugin')

module.exports = {
  plugins: [
    plugin(function({ addComponents }) {
      addComponents({
        // base styles
        '.btn': {
            padding: '.5rem 1rem',
            fontWeight: '600',
        },
        // variant for theme-two
        '.theme-two .btn': {
            borderRadius: '.25rem',
        }
        // ...
      })
    })
  ]
}

Would this work for you ?

from tw-colors.

ninox14 avatar ninox14 commented on June 14, 2024

This could work but the config file would grow with the quantity of themes and components
I feel like it would become a problem relatively fast

from tw-colors.

L-Blondy avatar L-Blondy commented on June 14, 2024

If you really want that feature, tw-colors exposes the resolveTwcConfig for library authors.

You can use it to resolve the colors, utilities and variants to inject into a custom plugin.

export const myCustomPlugin = (
   config = {},
   options = {},
) => {
   const resolved = resolveTwcConfig(config, options);

   return plugin(
      ({ addUtilities, addVariant }) => {
         // add the css variables to "@layer utilities"
         addUtilities(resolved.utilities);
         // This is how tw-colors injects the variants. 
         // You might omit this part, loop over your config to add your own variants
         // carefully check out the link in my first answer before proceeding, it contains somd warnings caveouts and examples. 
         // Also check out the source code (lib/index.ts) to see the usage with Typescript
         resolved.variants.forEach(({ name, definition }) => addVariant(name, definition));
      },
      // extend the colors config
      {
         theme: {
            extend: {
               colors: resolved.colors,
            },
         },
      },
   );
};

from tw-colors.

L-Blondy avatar L-Blondy commented on June 14, 2024

Added support for Variants without explicit theme declarations in v3.0.0

from tw-colors.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.