Code Monkey home page Code Monkey logo

Comments (4)

wannesvanloock avatar wannesvanloock commented on May 16, 2024

Multi-threaded reductions are likely to be non-deterministic, so probably this is a no-fix issue.

from cilantro.

kzampog avatar kzampog commented on May 16, 2024

Hi!

Indeed, this should happen due to the reduction. The latest commit before I introduced it was ced6281, which seems deterministic.

The reduction gives solid speedups (~50ms down to ~7ms of total optimization time -- correspondence search excluded -- in the example scenario on my machine), but if it behaves erratically I might have to revert back. How significant are the discrepancies you noticed?

Thanks for reporting this!

from cilantro.

wannesvanloock avatar wannesvanloock commented on May 16, 2024

I looked into the issue some more. The varying number of iterations was due to setting a tolerance of 1e-6. Due to the non-determinism, this sometimes caused rapid convergence or no convergence at all.
We could make determinism a compiler option. This way, no revert is required.

from cilantro.

kzampog avatar kzampog commented on May 16, 2024

Thanks for the suggestion! I added a CMake option to toggle non-deterministic reductions (enabled by default).

from cilantro.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.