Comments (3)
The problem in this case was the shunit_match_=`expr "${shunit_condition_}" :
'\([0-9]*\)'` which returned a 1. i attached an || true to ensure that return
value is always 0 (since it won't be evaluated by the script).
I also fixed the problem for the AssertEquals and AssertNotEquals functions.
there the problem came frmo failNotEquals.
One remaining problem is that an `assertTrue 1` will still cause the crash
since the assertion function returns failure in this case. I'm not sure if this
is a responsibility of the assetion function or the caller that should check
the return value. I tend to give the responsibility to the caller.
I did not write test yet because I'm not sure how this behaviour could be
tested.
Original comment by [email protected]
on 13 Sep 2013 at 11:49
Attachments:
from shunit2.
@kward this is quite a gotcha. Is this issue just waiting on someone to rebase the above patch on the latest shunit2 in master?
from shunit2.
Fixed by 6f6a642
from shunit2.
Related Issues (20)
- "Ran X tests." message is not accurate if a test exits
- fail fails to fail the test immediately HOT 4
- shunit2 Debian/Ubuntu packages out of date HOT 20
- Use https://bpkg.sh/ as package manager
- Warning "can only `return' from a function or sourced script" when executing in standalone mode (in Bash shell) HOT 1
- Should there be a counter for skipped tests in addition to the number of skipped asserts? HOT 5
- "[[: not found" error when sourcing files
- Test with bash in posix mode
- Next release ? HOT 4
- Mock and expect HOT 3
- Update version distributed through apt HOT 3
- [BASH] _SHUNIT_LINENO_ error if IFS is redefined HOT 4
- How to only execute specified test cases instead of all ? HOT 1
- What scenarios and how to use Error handling?
- Cannot source unit tests from unit tests HOT 1
- 执行单个案例,是否可以打印他的执行过程
- assertNotNull not working with set -e HOT 2
- egrep: warning: egrep is obsolescent; using grep -E HOT 5
- Add snapshot testing support
- want new version HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shunit2.