count is not considered when doing the check for actual_num_validators about ethereum-package HOT 7 CLOSED

I was able to reproduce this error, continuing to look into it.

from ethereum-package.

Its probably this line that needs adjusting, to use the count also: https://github.com/kurtosis-tech/eth2-package/blob/main/src/package_io/parse_input.star#L104

from ethereum-package.

@barnabasbusa I'm not sure what you mean about it shoud use the count as well? As I see it the immediate issue looks to be that slots_per_epoch is set to 32. Would it make sense to lower it? When I do it seems to run. But not sure what the best value is.

from ethereum-package.

this has nothing to do with slots_per_epoch. The count is a new participant parameter that can be configured.
Its basically requests that many sets of client pairs of a certain kind.
For example, it will create

teku-geth-01
teku-geth-02
...
teku-geth-10

lighthouse-geth-01
...

...
But instead it assumes that there is one occurrence of each, and thus, actual_num_validators is 5x10 = 50. (which is no longer the correct way to calculate how many validators there are actually)

from ethereum-package.

@barnabasbusa Got it! What would be the correct way?

Would it be summing up the counts in the array? If so, I can make that change.

from ethereum-package.

sum of all counts (default to 1 if count is not present) * num_validator_keys_per_node

from ethereum-package.

@barnabasbusa made a PR. I was unable to test it with count=10 for each participant as my laptop just doesn't have enough memory. But ran it with count=2 and it seems to be working. Let me know if you have any issues!

from ethereum-package.