missing gamma function when built against musl about kuroko HOT 4 CLOSED

Following the CPython approach, when I replace the stubbed versions of these functions in ToaruOS, the tgamma implementation can be included in Kuroko, but for now it seems all of the real-world targets have at least lgamma and tgamma these days.

from kuroko.

I was curious what CPython was doing with this mess and apparently it has in-house implementations for a handful of the "weirder" math functions - including gamma (and apparently the reason gamma is missing from Musl is because no one can agree on what function it's actually supposed to implement, so it was dropped from standards considerations).

from kuroko.

it's certainly an option to omit the binding altogether. I'm fine with whatever.

from kuroko.

I dropped math.gamma and have math.lgamma and math.tgamma bound to their libc counterparts, for consistency with the rest of the math module. For things that expect math.gamma (eg., ported Python code), math.gamma = math.tgamma should suffice, and I could bind that alias but have opted not to for now.

I was able to use musl-gcc to build against musl without issue and passed the test suite.

from kuroko.