Code Monkey home page Code Monkey logo

Comments (9)

Kureev avatar Kureev commented on July 22, 2024

I need to go deep into it. There are few issues related to this already

from react-native-side-menu.

piyushchauhan2011 avatar piyushchauhan2011 commented on July 22, 2024

👍

from react-native-side-menu.

Kureev avatar Kureev commented on July 22, 2024

The issue is that we need to recalculate layout after orientation has been changed. I found a library which solves this until facebook gonna support it on the "native" level: https://github.com/yamill/react-native-orientation.

from react-native-side-menu.

bright-sea avatar bright-sea commented on July 22, 2024

@Kureev Thanks for update!

This issue is very critical for us as this prevent us from deploy our app to production. With this issue, the user experience is really bad.

  1. Before facebook support that lib on the native level, any workaround for us? for example, Is it possible to add that lib as a dependence in react-native-side-menu?
  2. I saw all facebook react native component can handle this very well, is it possible ask their team member for help, for example, raise an issue in RN.

from react-native-side-menu.

ryanmcdermott avatar ryanmcdermott commented on July 22, 2024

I'm experiencing this bug as well.

Thanks for the awesome work :)

from react-native-side-menu.

bright-sea avatar bright-sea commented on July 22, 2024

This is an awesome work except this issue. With this issue not been fixed, I don't think this plugin can be used in any production.

Will think about remove all dependences of this plugin due to this issue. It's really a hard decision. :(

from react-native-side-menu.

ryanmcdermott avatar ryanmcdermott commented on July 22, 2024

For now, I've been locking the orientation which seems to work. You can do this inside your project navigator. If you don't need landscape mode I recommend this until the issue is fixed.
screen shot 2015-08-20 at 10 31 27 am

from react-native-side-menu.

Kureev avatar Kureev commented on July 22, 2024

I feel myself so sorry for not fixing it for a while. But it's not a critical bug, you can workaround it if you wish: use react-native-orientation library to detect orientation change and re-initialize side-menu, that will work. Basically, I even think that usual re-render will help (but I need to check). The reason why I haven't solved it yet, is that I really don't want to add native Obj-C module dependency. But I think I would, if so many people messed up with it.

from react-native-side-menu.

piyushchauhan2011 avatar piyushchauhan2011 commented on July 22, 2024

👍 @Kureev

from react-native-side-menu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.