Support React 0.7 and above about react-native-side-menu HOT 35 CLOSED

Unable to resolve module Dimensions from /Users/kartikeychauhan/Documents/testcodes/react-native-test/HelloTest/node_modules/react-native-side-menu/index.js
Unable to resolve module Dimensions from /Users/kartikeychauhan/Documents/testcodes/react-native-test/HelloTest/node_modules/react-native-side-menu/styles.js

👍

Although it does work perfectly 😄

from react-native-side-menu.

v0.9.3 has been released with this fix

from react-native-side-menu.

Thank you <3

from react-native-side-menu.

If it works, you can close an issue

from react-native-side-menu.

Will check in a bit, need to upgrate to React 0.7 again :)

from react-native-side-menu.

I feel sorry that you need to use prev. versions because of my components :(

from react-native-side-menu.

Doesn't work for me :(

from react-native-side-menu.

@piyushchauhan2011 Can you provide some more feedback what exactly doesn't work, and which versions you're using?

from react-native-side-menu.

I'm using version 0.7.1 react-native and it says Dimensions.get not an object.

I don't understand what is correct way.

var React, {
    StyleSheet,
    Dimensions,
} = require('react-native');

OR

var { Dimensions, } = require('Dimensions');
var React = require('react-native');

OR

var { React, Dimensions } = require('react-native');
var {
    StyleSheet,
} = React;

I do know that import { Dimensions } from 'react-native' is the newest api of importing stuff in javascript and is correct way but react-native doesn't support this way of doing things.

from react-native-side-menu.

Still using 0.9.2 version 😄

from react-native-side-menu.

AFAIK, Dimensions should be included from react-native package. That should be fixed in 0.9.2. Please, let me know if it doesn't work for you, @piyushchauhan2011

from react-native-side-menu.

I'm currently using 0.9.2 version which works fine but 0.9.3 version doesn't work for me. @Kureev

from react-native-side-menu.

Can you tell me why? @piyushchauhan2011

from react-native-side-menu.

This is the error i'm getting where index.js:12 is the file from your repository which have the code for Dimensions.
I have tried all the way of inclusion of Dimensions, but can't figure it out.

from react-native-side-menu.

Do you know which is the correct way of requiring dimensions ?

from react-native-side-menu.

Seems I don't. Will check the changelog and fix it asap

from react-native-side-menu.

I think they are still using the old way of requiring the dimensions.
This is from the master branch.

from react-native-side-menu.

I think you can check out 0.9.4, @piyushchauhan2011

from react-native-side-menu.

Cool.

from react-native-side-menu.

It says.

from react-native-side-menu.

Ah, it doesn't support class variables without flag, right

from react-native-side-menu.

I think you removed the constructor too 😄

from react-native-side-menu.

@piyushchauhan2011 constructor isn't necessary to override if you use class variables. But babel supports it only with stage=1 enabled (stage=2 enabled by default). I've changed it back in 0.9.5. Please, take a look (unable to test it now)

from react-native-side-menu.

Cool I checked the newest version, perfect work 👍 Thanks mate really appreciate it. Saved a lot of hours for me 🍺 @Kureev
Cheers! 0.9.5

from react-native-side-menu.

I also wanted to ask you about how to include testing in a project maybe later, if you have suggestion or links please paste it here 😃 @Kureev

from react-native-side-menu.

I'd like to do it, but now I'm really busy at work, so I don't have that much time for open source. I'm trying to improve it, but step by step. I don't have any proposal now, but I'm open to suggestions.

from react-native-side-menu.

@grabbou I've tried to change it to require from react-native, but for 0.7 it doesn't work. So I'll keep it current way until they would be close to deprecate it.

from react-native-side-menu.

👍 I think it will change in 0.8 release we have to change it then.

from react-native-side-menu.

Well, it was working with 0.7.1 yesterday, not sure why there are such differences ;( I am gonna fork it temporarily to see if I can upgrade, will let you know.

from react-native-side-menu.

@grabbou Sure, you can also check 0.9.3 patch commit, I've tried exactly you proposed in subj and it seems fb still doesn't support it or I've made something wrong :)

from react-native-side-menu.

Ah yeah, that's true. Thanks!

from react-native-side-menu.

Ok, I confirm it was false issue. It's not yet there in React 0.7, can we move back to previous version on master? :)

from react-native-side-menu.

I think we can just create a branch like [email protected] and agregate all breaking changes etc there, and when it'll be stable, we can just merge it into master

from react-native-side-menu.

But answering your question, you can be explicit about the version you want to use: [email protected]

from react-native-side-menu.

Yeah, that's what I did. Just worried some bugs / features might be implemented in the meantime :) But maybe it's worth waiting till 0.8/0.9 reaches the npm.

from react-native-side-menu.