iPad portrait about react-native-side-menu HOT 19 CLOSED

Have you tried flex: 1 for your views? Do you have your View stretched correctly without side menu?
To give you more feedback, I need screenshot and version of react-native and plugin you're using.

from react-native-side-menu.

i have react native version 0.6, and the side menu version 0.9.0 .

I am sending pictures of how it looks like by just putting the menu item , or just putting the content.

flex : 1 is on all these components.

from react-native-side-menu.

@Kureev

from react-native-side-menu.

Wow, that's really weird, I'll take a look

from react-native-side-menu.

@alinz fyi, mb you have any thoughts so far?

from react-native-side-menu.

i have found a hackish solution around it.

i used react-native-device module, and set the height of the container view using the height provided and it seems to work. but it would be really helpful if its sorted out.

from react-native-side-menu.

so if the issue is in the wrong height of the wrapper element - it's good, I can manage it easily. Thanks for this feedback, it'll scope my research and save my time ;)

from react-native-side-menu.

@jawadrehman You know, I took a look on implementation, and honestly I don't like it (I mean react-native-device). I prefer that kind of check made on iOS part. There is a nice gist for that https://gist.github.com/Jaybles/1323251 and I think I gonna implement that in the nearest future and plug it in as a dependency for side menu. That would help I guess.

from react-native-side-menu.

but why would you need to set the height, isnt there a way of using flex to
do this ?

On Fri, Jul 10, 2015 at 1:04 PM, Alexey [email protected] wrote:

@jawadrehman https://github.com/jawadrehman You know, I took a look on
implementation, and honestly I don't like it (I mean react-native-device).
I prefer that kind of check made on iOS part. There is a nice gist for that
https://gist.github.com/Jaybles/1323251 and I think I gonna implement
that in the nearest future and plug it in as a dependency for side menu.
That would help I guess.

—
Reply to this email directly or view it on GitHub
#65 (comment)
.

from react-native-side-menu.

because we already use it https://github.com/Kureev/react-native-side-menu/blob/master/styles.js#L10 and it seems not working.

from react-native-side-menu.

@jawadrehman btw, are you sure your bottom menu haven't any weird paddingTop or something?

from react-native-side-menu.

" width: deviceScreen.width,height: deviceScreen.height, " whats that about
?

On Fri, Jul 10, 2015 at 1:19 PM, Alexey [email protected] wrote:

because we already use it
https://github.com/Kureev/react-native-side-menu/blob/master/styles.js#L10
and it seems not working.

—
Reply to this email directly or view it on GitHub
#65 (comment)
.

from react-native-side-menu.

I have tried the example code, without the tab bar and navbar and it still
has that padding left at the bottom .

On Fri, Jul 10, 2015 at 1:20 PM, Alexey [email protected] wrote:

@jawadrehman https://github.com/jawadrehman btw, are you sure your
bottom menu haven't any weird paddingTop or something?

—
Reply to this email directly or view it on GitHub
#65 (comment)
.

from react-native-side-menu.

Yeah, that's weird. Maybe you're right about deviceScreen, until scroll it should works fine, but then it breaks, right? I'll try to fix it, but I can't use flex with position: absolute

from react-native-side-menu.

nah, it just has that padding as soon as the screen loads

On Fri, Jul 10, 2015 at 1:24 PM, Alexey [email protected] wrote:

Yeah, that's weird. Maybe you're right about deviceScreen, until scroll
it should works fine, but then it breaks, right?

—
Reply to this email directly or view it on GitHub
#65 (comment)
.

from react-native-side-menu.

You know, I tried to run my example on iPad Portrait and wasn't able to reproduce it. I'm running react-native 0.7.1 and react-native-side-menu 0.9.5. Maybe update to latest version would solve your issue?

from react-native-side-menu.

@brentvatne

from react-native-side-menu.

probably the same as #82

from react-native-side-menu.

Ok, we're not supporting RN0.6 any more, I will reopen you'll be able to experience this with latest version.

from react-native-side-menu.